4 ms·

The emailed patch model is still incredibly popular and combined with an application such as Patchwork remains efficient. good luck not messing up the formatti

The emailed patch model is still incredibly popular and combined with an application such as Patchwork remains efficient. good luck not messing up the formatting with a modern client $ git send-email GitHub is easier to get started with but both methods have their benefits. I personally prefer GitHub but don't have problems contributing to projects that use the emailed patch model.

laurentdc 10y ago
> $ git send-email Ah, thanks. If I only had known! :) Maybe someone at OpenWrt (with edit access to the Wiki and such) could write a simple script for git send-email with a wrapper for the [PATCH] [architecture] what subject and Signed-off-by thing. Would speed things up quite a bit imho, especially for newcomers. I see quite a few "not formatted properly" rejections.
- ycmbntrthrwaway 10y ago
  It is up to you to put "[architecture] what" into your commit message. Signed-off-by is a legal procedure, it should not be automated, you should do "git commit --signoff" yourself. "[PATCH]" is added by "git send-email". If you don't want to setup your client properly and keep using some GUI or Web client, you can format your patch with "git format-patch" and submit whatever files it produces. OpenWrt rightfully expects you to read at least "man giteveryday", which is titled "A useful minimum set of commands for Everyday Git" and includes "format-patch" and "send-email" in "INDIVIDUAL DEVELOPER (PARTICIPANT)" section.
- cyphar 10y ago
  Signed-off-by is automatically added to commits if you add "-s" to the git commit command. In addition, git format-patch (and thus git send-email) already adds [PATCH X/Y] to the subject line (prepended to the short commit message). Which part of this needs to be better scripted?
  - fake-name 10y ago
    The entire part where this shit happens using email.
    - cyphar 10y ago
      % git send-email Wow. So hard. So many characters.
  - jwilk 10y ago
    Adding -s every time is too much work, so I added this to my git config instead: [format] signOff = true
    - ycmbntrthrwaway 10y ago
      Just don't add it to global config

laurentdc 10y ago

> $ git send-email Ah, thanks. If I only had known! :) Maybe someone at OpenWrt (with edit access to the Wiki and such) could write a simple script for git send-email with a wrapper for the [PATCH] [architecture] what subject and Signed-off-by thing. Would speed things up quite a bit imho, especially for newcomers. I see quite a few "not formatted properly" rejections.

ycmbntrthrwaway 10y ago
It is up to you to put "[architecture] what" into your commit message. Signed-off-by is a legal procedure, it should not be automated, you should do "git commit --signoff" yourself. "[PATCH]" is added by "git send-email". If you don't want to setup your client properly and keep using some GUI or Web client, you can format your patch with "git format-patch" and submit whatever files it produces. OpenWrt rightfully expects you to read at least "man giteveryday", which is titled "A useful minimum set of commands for Everyday Git" and includes "format-patch" and "send-email" in "INDIVIDUAL DEVELOPER (PARTICIPANT)" section.
cyphar 10y ago
Signed-off-by is automatically added to commits if you add "-s" to the git commit command. In addition, git format-patch (and thus git send-email) already adds [PATCH X/Y] to the subject line (prepended to the short commit message). Which part of this needs to be better scripted?
- fake-name 10y ago
  The entire part where this shit happens using email.
  - cyphar 10y ago
    % git send-email Wow. So hard. So many characters.
- jwilk 10y ago
  Adding -s every time is too much work, so I added this to my git config instead: [format] signOff = true
  - ycmbntrthrwaway 10y ago
    Just don't add it to global config