3 ms·

I was subjected to this "Socratic" type of code review when I was younger and I didn't like it. I felt like I had to worry about what I thought the reviewer mig

• aninhumer 10y ago
  Yeah I feel like a lot of advice is describing what constructive critics do, rather than the attitudes that lead to it. If someone is humble, they'll naturally tend to ask questions as described. What you've written isn't what they expect, but they assume you're not an idiot and there's a reason for it, so they ask why. But if someone assumes they know better, the socratic method is likely to be just as condescending as just saying you're wrong.
  • matwood 10y ago
    > What you've written isn't what they expect, but they assume you're not an idiot and there's a reason for it, so they ask why. This is exactly why I ask questions. It's important in a code review to understand the frame of mind of the code writer. I presume the person is not an idiot and did things for a reason or will respond with a doh! it was late/that was careless/thanks I'll fix it.