4 ms·
I find that tone works when the developer has clearly thought things through. Other times, though, some developers need a very stern review. Things like: "Don'
by gwbas1c 10y ago
I find that tone works when the developer has clearly thought things through.
Other times, though, some developers need a very stern review. Things like: "Don't name your tests test1, test2, test3. Give them descriptive names," "Follow style," and "this does not belong in the dependency injector," and "don't screw with event publishing logic, filter this out in the event handler in the UI" are warranted when a developer isn't taking the time to think through his/her changes.
- bryanlarsen 10y agoA lot of that can be softened with "This is the project's style. I don't agree with everything in the style guide, but consistency is important." You can say that, even if you agree wholeheartedly with the part you're calling out.
- phkahler 10y agoNever say "do it this way". Try to explain why "this way" is better so they learn. If you don't they'll just think you're saying "my way is better" and resent you for it.
- icebraining 10y agoDoes being stern actually produce better results?
- gwbas1c 10y agoYes, much better. It establishes that we are a "clean code" shop, and that sloppiness isn't tolerated. This is important when dealing with junior contractors.
- JustSomeNobody 10y agoOr... bring the team in to review some old code that no one has touched in a while and give everyone the opportunity to critique it. Set those critiques as the bar for everyone's code review. Then, when you review the JD, if he has made those mistakes, you don't have to be stern, you just have to remind him (or her).
- matwood 10y agoStern really is the last resort mainly because the things that people really argue about are often just opinions. No one is going to argue that test1, test2, etc... are good test names. It is certainly better to let someone realize that on their own with a question than sternly tell them they are bad. The very rare times when I have to be stern is with consistency issues. Usually though, that's even softened with a "Yes this might be a better way to do it, but it is not consistent with how it has been done so far. We'll make some time in the future to change it everywhere, but for now stay consistent." Often times the biggest issue with juniors or even mid level people is they are only looking at their immediate piece, and not thinking about the larger application or system level picture.
- deleted 10y ago[deleted]
- kaikai 10y agoHow about... "Can you think of names for these tests that would be more helpful when we need to debug why they're failing?" "Check out the styleguide for indentation like this; consistent code is easier to maintain" "Here's a place where we did something similar. See how this logic goes over here instead? That helps us keep x, y, modular" Phrasing things a little differently can make feedback feel like a learning opportunity instead of a criticism.