5 ms·
Not talking about the project, but is the term 'LGTM' (looks good to me) used often in tech? I've heard it from Googlers but otherwise haven't really seen the t
by ninjakeyboard 10y ago
Not talking about the project, but is the term 'LGTM' (looks good to me) used often in tech? I've heard it from Googlers but otherwise haven't really seen the term in tech.
- reubenbond 10y agoIt's common at Microsoft to sign off on a code review with "LGTM".
- agnivade 10y agoYup, its used often. Atleast in my company(not Google), LGTM and SGTM are used pretty commonly.
- llamataboot 10y agoI've always had it as "Looks Good To Merge" -- we use it every day...
- ninjakeyboard 10y agoit's used more generally than in code. eg design doc review you'd say "LGTM" to say that there are no suggestions.
- percept 10y agoLet's Get The Manual
- mdk754 10y agoLet's get this merged!
- loeg 10y agoLooks Good to Me is commonly used in code review at my employer (not Google).
- Kunlun 10y agoSame here we are using it for most of our commits. When someone is done with their changes, they issue a PR which is reviewed by one or two team members before being rejected or merged by saying LGTM.
- Kunlun 10y agoSame here we are using it for most of our commits. When someone is done with their changes, they issue a PR which is reviewed by one or two team members before being rejected or merged by saying LGTM.
- colbyaley 10y agoIt's been used at companies I've worked at (not Google). I had a coworker who didn't know what it meant, and somehow assumed it was "Let's Get That Money". So now I think of that every time :)
- throwanem 10y agoSame here, for the same reason. Apparently that's a 50 Cent track - go fig!
- realityking 10y agoFor a long time, I actually thought it means "Let's Get That Moving". Still works.
- etjossem 10y agoDepends on the company, but at SendGrid it's standard practice in the code review stage to wait for Looks Good To Me - no more changes needed - before merging. Much like this submission, our continuous integration system (opsbot) doesn't let you continue through the workflow until you have a "LGTM" comment from another developer. This prevents lone-developer cowboy merges with no review. :)
- Larrikin 10y agoI had assumed it was very common. The small start up I worked at used it. One of the developers was really fond of using this plugin for all his LGTM comments https://chrome.google.com/webstore/detail/lgtm/oeacdmeoegfagkmiecjjikpfgebmalof?hl=en https://chrome.google.com/webstore/detail/lgtm/oeacdmeoegfag...
- krzyk 10y agoI also heard Google uses it, in none of my previous employees I've seen it (corporations).
- bubersson 10y agoGoogle uses LGTM quite heavily in UI labels and conversations, e.g. "I LGTMed it".
- joshschreuder 10y agoI think I picked it up from looking at Angular PRs but have spread it to my team so now we all use it.