3 ms·
It has not been fixed: I did a series of PRs on this [1] and the most impactful of them was not merged, although a few smaller ones were. @iarna got to the roo
by STRML 11y ago
It has not been fixed: I did a series of PRs on this [1] and the most impactful of them was not merged, although a few smaller ones were.
@iarna got to the root cause (instead of simply throttling it as I had been doing) but it has not yet been merged into npmlog. [2]
1. https://github.com/npm/npm/issues/11283#issuecomment-175752264 https://github.com/npm/npm/issues/11283#issuecomment-1757522...
2. https://github.com/npm/npmlog/pull/28 https://github.com/npm/npmlog/pull/28
- joshschreuder 11y agoFair enough, I'm not up with npm's development on a PR level, so I was just going by this line in the changelog: "This has been patched to eliminate that churn, and our testing shows the progress bar as being eliminated as a source of slow down." Apologies for being misleading.
- STRML 11y agoJust to update you - looks like this has finally been released: https://github.com/npm/npm/releases/tag/v3.8.3 https://github.com/npm/npm/releases/tag/v3.8.3
- joshschreuder 11y agoGreat, thanks! I'll check it out. Unfortunately I've not had much luck getting pnpm or ied running on Windows due to the symlinking stuff (though the installation portion is super quick), so hopefully the speed improvements here can help lessen the blow a bit.
- joshschreuder 11y agoAs an aside, why does npm check-in the node_modules folder into their repo? I was under the impression this was generally considered bad practice, so it seemed weird seeing it done by the package manager itself :)