4 ms·
Why not use enum? https://github.com/Hypsurus/skod/blob/master/src/skod.c#L290 https://github.com/Hypsurus/skod/blob/master/src/skod.c#L290 Also, at least som
by ycmbntrthrwaway 11y ago
Why not use enum?
https://github.com/Hypsurus/skod/blob/master/src/skod.c#L290 https://github.com/Hypsurus/skod/blob/master/src/skod.c#L290
Also, at least some functions should be static.
_cla means "command line arguments", not obvious.
Useless comments: https://github.com/Hypsurus/skod/blob/master/src/skod.c#L273 https://github.com/Hypsurus/skod/blob/master/src/skod.c#L273
- gravypod 11y agoNot my software, but if you have looked at other FTP clients this is an amazing thing to read though.
- ycmbntrthrwaway 11y agoOther clients code being bad does not make this code easy to read or beautiful. All those MAX_STR and strcat's make me wonder about security: https://github.com/Hypsurus/skod/blob/master/src/ftp.c#L14 https://github.com/Hypsurus/skod/blob/master/src/ftp.c#L14 Amazing read: https://github.com/Hypsurus/skod/blob/master/src/ftp.c#L22 https://github.com/Hypsurus/skod/blob/master/src/ftp.c#L22 No enum again: https://github.com/Hypsurus/skod/blob/master/src/utils.c#L14 https://github.com/Hypsurus/skod/blob/master/src/utils.c#L14
- gravypod 11y agoI hold it to a standard of how to organize your code. The organization of the source is superb. Even without much documentation, you can go through and read it while understanding what is happening.
- lobster_johnson 11y agoLots of missing error checks. fwrite() can fail -- this code just ignores it. No thanks!