5 ms·
What a misleading title! He's speaking approvingly of pull-request-based workflow, which is not what anyone is going to think the title of the article means.
by greglindahl 11y ago
What a misleading title! He's speaking approvingly of pull-request-based workflow, which is not what anyone is going to think the title of the article means.
- zeckalpha 11y agoThat's not how I read it. I read it as, don't push directly to master.
- greglindahl 11y agoDon't push directly to master isn't what anyone is going to think the title of the article means, either.
- ghusbands 11y agoYou're saying that in reply to someone who clearly did, which seems disingenuous. I also read it the way the author intended.
- klodolph 11y agoI don't think "disingenuous" is necessarily appropriate here. When people say "anyone" they don't generally mean "anyone, without exception".
- AznHisoka 11y agoNever assume or generalize. I thought that's what the title meant as well.
- mikeash 11y agoI assumed the title couldn't possibly mean that, but I also had no idea what else it could mean.
- zeckalpha 11y agoWhy couldn't the title mean that? It's not an unreasonable restriction.
- mikeash 11y agoSorry, I'm referring a bit too far up the chain with "that." The only meaning I could imagine for the title was that one shouldn't place code into source control at all before code review, which is too absurd to possibly be what was meant.
- deleted 11y ago[deleted]
- koko775 11y ago(oops! sorry for the accidental flag. I was trying to reply and misclicked) That's the very first thing that occurred to me, actually.
- rhpistole 11y agoFurthermore it's mostly a rant against subversion rather than going making any kind of argument about his assertions. Plus anybody who advocates the use of git rebase --interactive as a sensible response to code review feedback is clearly insane.
- MrRadar 11y ago> Furthermore it's mostly a rant against subversion rather than going making any kind of argument about his assertions. A completely misguided rant at that. The author even admits it: "To be fair, you can adopt this workflow with Subversion, using either task branches or patches..." This is exactly how my team uses Subversion (and used CVS before it; yes, we used this exact "branch per issue, code review before merge" workflow with CVS up through 2013) and we don't find the overhead of branching and merging onerous. Granted, I haven't ever tried contributing to an open source project using SVN, but arguably Git is the more-correct tool for that kind of development anyways.
- hyperpape 11y agoWe use branches with SVN, but it's slow and creates a lot of overhead on quick tasks. People who can get away with it work out of trunk and commit directly to trunk when they can.
- jsolson 11y ago> Plus anybody who advocates the use of git rebase --interactive as a sensible response to code review feedback is clearly insane. Why? Prior to a series of changes being pulled into someone else's history you have all the incentive in the world to present the cleanest view of history possible. Moreover, if you can rebase -i on top of master you can turn the merge into a fast-forward rather than an actual merge. A more linear history with fewer merges is much easier to bisect as well as to read, generally.
- ghusbands 11y agoYou present a clean history, yes, but not a correct one. The context in which you made your changes, often noted as important, has been lost.
- joshschreuder 11y agoI agree, I thought the argument was going to be against code reviewing branches, not for it.
- ajdlinux 11y agoMy first thought was pull-request or patch-based workflow, but then again my day job involves the Linux kernel, and all the other projects at my workplace have adopted the kernel workflow and code review process as standard...
- SilasX 11y agoYeah I read it and am still confused: Subversion doesn't let you have branches like git, where it's just some version of the code people can toy around with on their machines without affecting anyone? Any sharing of code to the central repo blocks further work? If true, that seems like Stone Age code workflow. You might as well argue that code should be tested before deployment rather than edited on production directly, or that it's a really neat idea to keep track of who changed what code when. Duh?
- mooreds 11y agoSubversion does let you have branches, but every shop I have worked in that used subversion used branches rarely, if at all. The branch-merge default of git is really remarkable, and is baked into the tool and the community.
- Grue3 11y agoOn the other hand, in one shop where I worked we not only used Subversion branches, but also a modified GitFlow adapted for Subversion. It worked pretty well.
- klodolph 11y agoYes. I currently use Subversion at work, and the only way I keep things working smoothly is by using Git locally, and then checking changes from Git into Subversion when they're fully tested (at least developer-tested, not QA-tested). A coworker recently asked permission to branch, and our manager denied the request. The last time my workflow was like this was back in the 1990s, and it certainly feels like the stone age.