jacobegold

6 ms·

31.
by jacobegold 3y ago
I think that this video should be considered mandatory viewing if you're a developer using Git — the whole lecture starts from the basic data structures involved and builds from there, as opposed to the way that it seems many people ap
32.
by jacobegold 3y ago
were they stacked tho
33.
by jacobegold 3y ago
I'm keeping an eye on Pierre ( https://pierre.co/ ) as well — not being subject to the whims of GitHub makes for some interesting ideas!
34.
by jacobegold 3y ago
I was lucky enough to work at a company with a great code review tool at one of my first positions -- and I am nowhere near convinced that GH's review interface is the simplest possible. Of course, everyone (including myself!) is proba
35.
by jacobegold 3y ago
They must have refs on the internal git servers -- they need them for the "force pushed from X to Y" timeline events
36.
by jacobegold 3y ago
How you do PRs is definitely important, and should be part of a company's consideration here, but remember that PRs are already a layer of abstraction over the SCM. Self-hosting Git is definitely not as easy as setting up a GH account
37.
by jacobegold 3y ago
Not to mention the value of a diff/pull request/changelist/patch/merge request (so many names...) and its corresponding discussion as a historical artifact for your team to reference later on!
38.
by jacobegold 3y ago
GitHub actually stores all the data necessary to do this without changing your ref model as the article suggests — even if you force push, it never garbage collects the commits that the branch used to point to. I work on a tool that include
39.
by jacobegold 3y ago
There are tools that solve this problem! I work on one (Graphite), but there's also plenty of others like git-branchless and Sapling. All three of these are inspired by Facebook's internal fork of Mercurial (with Phabricator&#x2F
40.
by jacobegold 3y ago
I used to work at FB, and unfortunately the Sapling review client that shows GH PRs has nothing on the the actual internal code review tooling at Facebook (now called Diffs, formerly Phabricator). I miss that tool so much
41.
by jacobegold 3y ago
Large OSS feels like a different use case than the big company one, to be honest -- I think that what maintainers care about is vastly different than what companies do. GitHub feels optimized for the former (OSS) as it is today.
42.
by jacobegold 3y ago
Better tooling is definitely the answer here -- I used to work at Facebook where rebasing dependent patches in Mercurial when you needed to adjust something felt like a first-classed flow, and I'm currently working on a tool that does
43.
by jacobegold 3y ago
This is what Facebook did extremely well with Phabricator, which was then open sourced.
44.
by jacobegold 3y ago
So sorry about that! If you update to the latest version of v1, we added a check to verify your Git version is up to date -- we use a feature from v2.38. Reach out to me (Jacob Gold) on our Slack Community if you're still seeing this
45.
Graphite for Visual Studio Code(graphite.dev)
10 points by jacobegold 3y ago|1 comments
46.
by jacobegold 3y ago
Building Graphite with Graphite is oh so satisfying, but sometimes I forget to look through the lens of someone less familiar with the product! Any users of the tool have interesting thoughts on what we might be able to improve?
47.
by jacobegold 3y ago
This feels likely!
48.
by jacobegold 3y ago
Wait until you see what the research shows about PR descriptions
49.
by jacobegold 3y ago
GitHub's market share percentage is a multiple of AWS's — and also, GitHub is just the beginning for us!
50.
by jacobegold 3y ago
What's the difference between a merge queue and a pull queue?
51.
by jacobegold 4y ago
But you can still construct stacked PRs out of the 2500-line change even you write it all at once -- just go back and split the changes into a series of PRs that makes sense. Much easier for your reviewers to get through, so it'll be
52.
by jacobegold 4y ago
The advantage of using stacks, though, is that you can keep focus on what you're working on, or even still work on 2-3 things simultaneously but work on multiple dependent pieces of each at once. Maybe I'm biased because I'v
53.
by jacobegold 5y ago
So funny :) I was on storage but was "moonlighting" on Iris for my last couple months at FB — what a small world! Feel free to shoot me an email if you don't want to wait, although the list moves fairly quickly these days.
54.
by jacobegold 5y ago
Try out Graphite! Half of us are ex-FB, so we get it. https://graphite.dev/
55.
by jacobegold 5y ago
Send an email (from the address you use to sign into GitHub!) to jacob@graphite.dev :)