4 ms·

Awesome! Remove the built-in web server and count me in!

by kolev 11y ago

lcnmrn 11y ago
The built-in web server is optional anyway.
- kolev 11y ago
  Via configuration, but it's bundled into the code. I'd rather have the web server as an optional install.
  - lemevi 11y ago
    I don't think it automatically starts up. You have to run fish-config to start it yes? $ fish_config Web config started at 'file:///Users/bjorn/.cache/fish/web_config-6VIDFM.html'. Hit enter to stop. ::1 - - [12/Jul/2015 11:13:31] code 403, message Forbidden When I kill this and refresh the config in the browser doesn't load anymore. So I don't see the problem.
    - kolev 11y ago
      Not to repeat myself: https://news.ycombinator.com/item?id=9877949 https://news.ycombinator.com/item?id=9877949
iagooar 11y ago
What's the issue with the web server?
- JupiterMoon 11y ago
  Some people might think that it might represent an extra volume of code for bugs to creep in - and hence security issues?
  - kolev 11y ago
    It just makes Fish feel desktopy, a toy shell, and not something serious. Ask the vim crowd that even in 2015 uses vim in the terminal, even on desktops. You just don't do the things Fish does, it's that simple. Make the web server an addon and keep everybody happy!
    - mralvar 11y ago
      You want the web server to be an add-on so you can feel more hardcore?
      - kolev 11y ago
        I was being sarcastic, but I don't really like the idea of my shell having a built-in web server even if it's just a few lines of code - feels like a Rube Goldberg machine. You can do nice TUIs in the console as well, even with graphics, but it's not necessary in this case. Configuration files are just fine for nearly 100% of the people who use Fish.
        ridiculous_fish 11y ago
        You may feel better to know that the web server is not part of the shell itself. It's a separate Python script that does its work by invoking fish and sending it commands. Its source is here: https://github.com/fish-shell/fish-shell/blob/master/share/tools/web_config/webconfig.py https://github.com/fish-shell/fish-shell/blob/master/share/t...
        kolev 11y ago
        You guys keep beating around the bush and keep downvoting me! Is the web server built-in? Yes, it is. Why do you keep finding excuses and why do you keep downvoting the voice of reasons - a shell should not have a web server in its codebase, period. Put this into an optional package and make everybody happy!
        11y ago
ytjohn 11y ago
The web server is only active if you run the command fish_config. When you run this command, if finds the next available port, starting at localhost:8000 and opens a web browser pointing to that port. Once in the web interface, you can click around to implement some pre-supplied recipies to your fish configuration. If you hit ctrl-c, the fish_config program exits and stops listening on the port. It's something you either run or you don't.

Awesome! Remove the built-in web server and count me in!

by kolev 11y ago

Awesome! Remove the built-in web server and count me in!

lcnmrn 11y ago

The built-in web server is optional anyway.

kolev 11y ago
Via configuration, but it's bundled into the code. I'd rather have the web server as an optional install.
- lemevi 11y ago
  I don't think it automatically starts up. You have to run fish-config to start it yes? $ fish_config Web config started at 'file:///Users/bjorn/.cache/fish/web_config-6VIDFM.html'. Hit enter to stop. ::1 - - [12/Jul/2015 11:13:31] code 403, message Forbidden When I kill this and refresh the config in the browser doesn't load anymore. So I don't see the problem.
  - kolev 11y ago
    Not to repeat myself: https://news.ycombinator.com/item?id=9877949 https://news.ycombinator.com/item?id=9877949

iagooar 11y ago

What's the issue with the web server?

JupiterMoon 11y ago
Some people might think that it might represent an extra volume of code for bugs to creep in - and hence security issues?
- kolev 11y ago
  It just makes Fish feel desktopy, a toy shell, and not something serious. Ask the vim crowd that even in 2015 uses vim in the terminal, even on desktops. You just don't do the things Fish does, it's that simple. Make the web server an addon and keep everybody happy!
  - mralvar 11y ago
    You want the web server to be an add-on so you can feel more hardcore?
    - kolev 11y ago
      I was being sarcastic, but I don't really like the idea of my shell having a built-in web server even if it's just a few lines of code - feels like a Rube Goldberg machine. You can do nice TUIs in the console as well, even with graphics, but it's not necessary in this case. Configuration files are just fine for nearly 100% of the people who use Fish.
      - ridiculous_fish 11y ago
        You may feel better to know that the web server is not part of the shell itself. It's a separate Python script that does its work by invoking fish and sending it commands. Its source is here: https://github.com/fish-shell/fish-shell/blob/master/share/tools/web_config/webconfig.py https://github.com/fish-shell/fish-shell/blob/master/share/t...
        kolev 11y ago
        You guys keep beating around the bush and keep downvoting me! Is the web server built-in? Yes, it is. Why do you keep finding excuses and why do you keep downvoting the voice of reasons - a shell should not have a web server in its codebase, period. Put this into an optional package and make everybody happy!
        11y ago

ytjohn 11y ago

The web server is only active if you run the command fish_config. When you run this command, if finds the next available port, starting at localhost:8000 and opens a web browser pointing to that port. Once in the web interface, you can click around to implement some pre-supplied recipies to your fish configuration. If you hit ctrl-c, the fish_config program exits and stops listening on the port. It's something you either run or you don't.