3 ms·
Moxie and Frederic and Christine and the rest definitely deserve a lot of credit. Half of me is really happy every time I see Signal getting more popular. The
by Strilanc 11y ago
Moxie and Frederic and Christine and the rest definitely deserve a lot of credit.
Half of me is really happy every time I see Signal getting more popular. The other half is more like OH GOD THE STAKES ARE HIGHER NOW WHAT IF I MADE AN EXPLOITABLE MISTAKE BETTER RE-READ SOME CODE.
But seriously, you should read the code. It's there, open for anyone to audit after all. Maybe start somewhere random in the guts [1][2][3] and check for things like "ereh 2# roodkcab"?
1: https://github.com/WhisperSystems/Signal-iOS/blob/master/Signal/src/network/rtp/zrtp/ZrtpResponder.m https://github.com/WhisperSystems/Signal-iOS/blob/master/Sig...
2: https://github.com/WhisperSystems/Signal-iOS/blob/master/Signal/src/crypto/EvpSymetricUtil.m https://github.com/WhisperSystems/Signal-iOS/blob/master/Sig...
3: https://github.com/WhisperSystems/Signal-iOS/blob/master/Signal/src/textsecure/Util/Cryptography.m https://github.com/WhisperSystems/Signal-iOS/blob/master/Sig...
- lukeh 11y ago+[Cryptography generateRandomBytes] should possibly return NSData rather than NSMutableData.