3 ms·
I tried contributing a nav change in the past (https://github.com/gitlabhq/gitlabhq/pull/6287 https://github.com/gitlabhq/gitlabhq/pull/6287) and it was closed
by jbrooksuk 11y ago
I tried contributing a nav change in the past (https://github.com/gitlabhq/gitlabhq/pull/6287 https://github.com/gitlabhq/gitlabhq/pull/6287) and it was closed because the CEO doesn't want it like that. That's one, limited example, but with the size of the change required to make the sidebar better, it could end up being a massive waste of time.
Still, I'll be closely watching GitLab and upgrading every few releases.
- jobvandervoort 11y agoI understand that it's disappointing if your PR doesn't gets merged. If you want to do something big, you should consider writing a proposal first in one of our issue trackers or on feedback.gitlab.com. In the same line, consider just creating a prototype / proposal or MVP of whatever you're building first. There are many people at GitLab happy to help you get rolling and get the PR merged. At the same time, if you're completely off-track, we'll also tell you that. The best way to not waste time is to communicate before, during and after any effort.
- jbrooksuk 11y agoI'm not complaining that my PR wasn't merged :)
- sytse 11y agoThanks for the link to the pull request. The benefit you stated was "I find this most useful since I can quickly jump back to a namespace, or search etc.". I think that 7.12 allows this by always showing the namespace and search on top. Please let me know if I misunderstand.