3 ms·
Personally, I say if a statement continues on a different line, then you should use braces //okay if (condition) return foo; //not okay if (co
by tracker1 11y ago
Personally, I say if a statement continues on a different line, then you should use braces
//okay
if (condition) return foo;
//not okay
if (condition)
return foo;
//not okay
if (condition) do_foo();
else do_bar();
In the second case, the else can be considered a continuation. In the first example, there's little chance of confusion or the introduction of an error, in the second and third, that is not necessarily the case.
If it doesn't look/fit well on one line, break it up with braces.
- breakingcups 11y agoWhat about: if((somevar != checkvar((byte)othervar)) & (i != 3)) somefunc(); someotherfunc(); A bit exaggerating, I agree, but not far off from some real-world examples and quite confusing.
- tracker1 11y agoNice, in that case, I might advocate for either somefunc or a function in front of it taking somevar, othervar and i as parameters with early return statements before falling through to the work.. returning a boolean for if they passed through... I've seen far, far, far worse...