3 ms·

If it's so short, why not give it a shot and put it up for code review so others can catch the nasty and insecure bits? Great learning experience :)

by lfowles 11y ago

collyw 11y ago
Where would you put it up for review?
- _asummers 11y ago
  https://codereview.stackexchange.com https://codereview.stackexchange.com or the project itself.
- deleted 11y ago
  [deleted]
- phuff 11y ago
  Put it up as a gist on github. Or put it up as a PR on github. Branches are cheap! :)
- atsaloli 11y ago
  The PostgreSQL developers team lives on the pgsql-hackers mailing list (http://www.postgresql.org/list/pgsql-hackers/ http://www.postgresql.org/list/pgsql-hackers/) which is appropriate for discussion of current development issues, problems and bugs, and PROPOSED NEW FEATURES. =) See also http://www.postgresql.org/developer/ http://www.postgresql.org/developer/
  - anarazel 11y ago
    But it's not a postgresql feature, it's a libgit feature. That said, you might still get a review out of it, but it's certainly not the obviously correct place.
    - atsaloli 11y ago
      Oops. Thanks for the correction.
andrewstuart 11y ago
It would be good if it was awesomely and expertly done rather than amateurish, which my fumbling would result it. Good idea though, time I started getting some C skills but on a less important bit of code.
- phuff 11y ago
  Courage! You can do it! It would also be a great learning opportunity since you have the other 2 libs to use as an example. You should go for it and then put it up for code reviews before using it. Seriously! Give it a shot and then ask HN to review it in another Ask HN.
- exDM69 11y ago
  This doesn't look too difficult to do (definitely not a "wizard" level task), and I think there will be more work in setting up tests, etc than actually writing the code. A good learning opportunity so if you've got the time go ahead and do it yourself. If you end up doing it yourself, I'll volunteer to do a quick review.
- angersock 11y ago
  Unless you're doing this for a business use case (which your insistence on expert quality and security earlier kinda suggest), it shouldn't matter. Don't fish for free work when you could turn this into a learning opportunity. Besides, why would you want to use PG as a backing store unless you were doing weird multitenant stuff?
  - andrewstuart 11y ago
    I'm a sole developer in pyjamas coding in the lounge room trying to come up with an idea that will make an income when I'm not doing my day job to pay the bills, in case you're asking if I am a rich company trying to get free development services. I'm happy to reciprocate technical services if what I know is of value. I write open source code too so I'm contributing although not to the libgit2 project. Same as many other developers here on HN I suspect. Coding in the hope of building something people want to use.
Zenst 11y ago
I had a quick look and agreed for a learning exercise this would be fantastic and given you have two existing examples to compare with it would be possible to work it out and learn some C at the same time and even if you did not know C; You would be able to hack it together without much brain taxing.

If it's so short, why not give it a shot and put it up for code review so others can catch the nasty and insecure bits? Great learning experience :)

by lfowles 11y ago

If it's so short, why not give it a shot and put it up for code review so others can catch the nasty and insecure bits? Great learning experience :)

collyw 11y ago

Where would you put it up for review?

_asummers 11y ago
https://codereview.stackexchange.com https://codereview.stackexchange.com or the project itself.
deleted 11y ago
[deleted]
phuff 11y ago
Put it up as a gist on github. Or put it up as a PR on github. Branches are cheap! :)
atsaloli 11y ago
The PostgreSQL developers team lives on the pgsql-hackers mailing list (http://www.postgresql.org/list/pgsql-hackers/ http://www.postgresql.org/list/pgsql-hackers/) which is appropriate for discussion of current development issues, problems and bugs, and PROPOSED NEW FEATURES. =) See also http://www.postgresql.org/developer/ http://www.postgresql.org/developer/
- anarazel 11y ago
  But it's not a postgresql feature, it's a libgit feature. That said, you might still get a review out of it, but it's certainly not the obviously correct place.
  - atsaloli 11y ago
    Oops. Thanks for the correction.

andrewstuart 11y ago

It would be good if it was awesomely and expertly done rather than amateurish, which my fumbling would result it. Good idea though, time I started getting some C skills but on a less important bit of code.

phuff 11y ago
Courage! You can do it! It would also be a great learning opportunity since you have the other 2 libs to use as an example. You should go for it and then put it up for code reviews before using it. Seriously! Give it a shot and then ask HN to review it in another Ask HN.
exDM69 11y ago
This doesn't look too difficult to do (definitely not a "wizard" level task), and I think there will be more work in setting up tests, etc than actually writing the code. A good learning opportunity so if you've got the time go ahead and do it yourself. If you end up doing it yourself, I'll volunteer to do a quick review.
angersock 11y ago
Unless you're doing this for a business use case (which your insistence on expert quality and security earlier kinda suggest), it shouldn't matter. Don't fish for free work when you could turn this into a learning opportunity. Besides, why would you want to use PG as a backing store unless you were doing weird multitenant stuff?
- andrewstuart 11y ago
  I'm a sole developer in pyjamas coding in the lounge room trying to come up with an idea that will make an income when I'm not doing my day job to pay the bills, in case you're asking if I am a rich company trying to get free development services. I'm happy to reciprocate technical services if what I know is of value. I write open source code too so I'm contributing although not to the libgit2 project. Same as many other developers here on HN I suspect. Coding in the hope of building something people want to use.

Zenst 11y ago

I had a quick look and agreed for a learning exercise this would be fantastic and given you have two existing examples to compare with it would be possible to work it out and learn some C at the same time and even if you did not know C; You would be able to hack it together without much brain taxing.