4 ms·
Implicit returns encourage functional style; foo.map(|x| x + 1) is so much nicer than foo.map(|x| { return x + 1; }). Once you have implicit returns in closures
by pcwalton 11y ago
Implicit returns encourage functional style; foo.map(|x| x + 1) is so much nicer than foo.map(|x| { return x + 1; }). Once you have implicit returns in closures, you might as well have them everywhere for consistency.
- veddan 11y agoI think that the "expression-style" return looks good for short and "expression-like" function. Good fn inc(a: u32) -> u32 { a + 1 } fn foo(a: u32, b: u32) -> u32 { let x = a + b; a * x } Bad fn bar(...) -> bool { let mut success = false; let conn = getConnection(); ... if x > y { return false; } else if z < q { success = false; } foo.barify(x, y); ... success } It looks especially bad when the function has multiple early returns, and then the final return looks different.
- Eerie 11y agoSheesh, it's such a little thing. "success" vs "return success;"
- cmrx64 11y agoDoesn't work when you're not returning from a function (ie, EVERY OTHER PLACE a block can appear)
- ewillbefull 11y agoThis could easily be added as a lint to the codebase.
- 88e282102ae2e5b 11y agoWhy "might as well"? Things can be optimal in some places and suboptimal elsewhere.
- lmm 11y agoConsistency is valuable. If some blocks have different rules to other blocks that's a real downside.
- 88e282102ae2e5b 11y agoThat's true, but they're so syntactically different that I can't imagine a scenario where someone is asking whether it's closures or functions that you're supposed to use return statements in.
- Sanddancer 11y agoA foolish consistency is the hobgoblin of little minds. Sometimes a variation in rules allows for more clarity -- one could set their editor to make return a different color, for example, making it easier to glance at program flow. Then again, I'd argue that closures should allow returns too, like they do in C#. I'm an adamant supporter of the explicit camp -- when you have to debug things at 3 in the morning, sometimes that extra little bit of context can make things blindingly obvious.
- pcwalton 11y agoClosures do allow returns in Rust.
- lmm 11y agoI find the way it works in scala very nice - a block is just an expression that evaluates to the last statement in the block, and idiomatic code never uses "return" anywhere. Even e.g. a function definition, you can replace the block with a single expression if it's more convenient. I agree with being explicit but I don't think return actually makes things any more explicit (if you're talking about an editor highlighting, the editor knows which line is the value of the block, with or without a "return") - rather it's just syntactic ceremony. It's surprising how much difference having very low-overhead closures makes - you can make so much of your program simpler, because it's not a problem if a caller needs to make a slight modification to something.
- carterehsmith 11y ago> foo.map(|x| x + 1) is so much nicer than foo.map(|x| { return x + 1; }) "Nicer" is a subjective thing. BTW in the trivial case above one may judge this or that to be nicer, but in a large method, 'return func(a,b,c)' is obvious, whereas looking at 'func(a,b,c)' it is super non-obvious that the value is being returned.
- nbouscal 11y agoIt's not at all non-obvious if you learn the language. It's also not non-obvious if you learn any of the myriad other languages with the same semantics (including popular web languages like Ruby and CoffeeScript).
- jnordwick 11y agocompromise. Make return very short, like a unary colon ":". Then "foo.map(|x| :x+1)" is nice. If that doesn't stand out enough for some people on a line of its own, make your editor render the unary colon line in a very bold color for you.
- eddyb 11y agoThat doesn't solve the fact that blocks and conditional control flow (if/else and match) are expressions and need a way to produce values.