4 ms·
Having seen this updated version I'm not terribly impressed at their guide for ES6. No mention of symbols (which are pretty important if you're using classes),
by thomasfoster96 11y ago
Having seen this updated version I'm not terribly impressed at their guide for ES6. No mention of symbols (which are pretty important if you're using classes), generators are ignored almost entirely, a pretty poor explanation of modules, etc.
- uptown 11y agoYou're in luck! They published this in GitHub so you can suggest changes you think might make things better.
- dikaiosune 11y agoThis has always been one characteristic of open source standpoints that I'm not such a big fan of. It's too tightly coupled to expect everyone with constructive criticism to also contribute. Yes, it would be good if they did. But it would strike a serious blow to many projects' mental capital if the only feedback they took from users was from those users capable (either technically or in possession of enough free time) of contributing the changes themselves.
- thomasfoster96 11y agoWell, style guides are fairly subjective projects compared to most other open source projects, so while it might be worth my while suggesting things, it's not likely airbnb is going to change their style guide because I think differently to them. Edit: Looking at some issues in the style guide repo, AirBnB seems reluctant to add or change the style guide to deviate from what they do internally (for instance, generators are rarely used, therefore they aren't encouraged).
- anustart666 11y agoDid you even read it? They don't use the meme 'symbols' but clearly mention 'dynamic property names'. https://github.com/airbnb/javascript#3.4 https://github.com/airbnb/javascript#3.4
- thomasfoster96 11y agoDynamic property names are quite different to Symbols in ECMAScript 6.
- anustart666 11y agoUse a global const for keygen, 'symbol' is most likely just a syntactic sugar for global const...
- thomasfoster96 11y agoWell a Symbol is guaranteed to be unique (unless you use the symbol registry) and can't be converted to a string - things that you can't say about a global const that is a string.
- Ronsenshi 11y agoUm: > Don't use generators for now. >> Why? They don't transpile well to ES5. Same thing with Symbols?