3 ms·
In this case, I'd argue that the names are still bad for a couple of reasons. Firstly, it's too verbose - a nice middle ground would have been better: calculat
by JamesMcMinn 11y ago
In this case, I'd argue that the names are still bad for a couple of reasons.
Firstly, it's too verbose - a nice middle ground would have been better: calculateTransferTax(Double transferValue, Double tax). It's fairly clear what the tax is being calculated over.
Secondly, I'd say that "tax" is a bad name for the tax percentage since it doesn't describe that what actually is (the percentage / rate of tax), and since it's a Double, I'd expect it to be "0.2" for a 20% tax rather than 20.0 which appears to be what the method would actually expect.