3 ms·
One thing I really like and appreciate is that there's a dockerfile right in the root of the project, which makes spinning up a container a relatively nice expe
by tracker1 11y ago
One thing I really like and appreciate is that there's a dockerfile right in the root of the project, which makes spinning up a container a relatively nice experience... haven't run it or looked into the code though... that just struck out at me...
Looking at the dockerfile, it seems pretty big, and it also strikes me slightly that they have dependencies on node, ruby and go, along with mysql and redis. The UI appears to be react based.. not sure what's running in ruby.
- ctolsen 11y agoI definitely appreciate projects having Dockerfiles included, but yeah, that's not a good one. They should simply include instructions about how to link it to MySQL/Redis, or use something like docker-compose. The way it's done now makes it inherently unscalable. Also, there are so many steps that it makes pushing an image to a Docker repository a massive pain.
- pibefision 11y ago+1 for a Docker Compose file
- sehr 11y agoLooks like it's only being used for their scss files.
- sciurus 11y agoI think it's nice that they support Docker, but I was disappointed that their entire installation instructions were "install docker then run our image". I had to read the dockerfile and the "start" script to find out what the actual dependencies and setup steps are. https://github.com/mattermost/platform/blob/master/Dockerfile https://github.com/mattermost/platform/blob/master/Dockerfil... https://github.com/mattermost/platform/blob/master/docker/docker-entry.sh https://github.com/mattermost/platform/blob/master/docker/do... Surely even docker users don't want to run this app, mysql, postfix, redis, react, and compass all in the same container?
- ptman 11y agoI agree that a dockerfile isn't perfect, but it's not that bad either as a machine readable install guide that doesn't fall out of date as easily as documentation written for human consumption.