5 ms·

Then someone else rebases over that commit, there's a conflict and lo! the tests fail. Why? typo. It's fixed in the subsequent commit (which you can't see). Lov

by hayd 11y ago

Then someone else rebases over that commit, there's a conflict and lo! the tests fail. Why? typo. It's fixed in the subsequent commit (which you can't see). Lovely. There's something to be said for having every commit pass tests/work (or if it doesn't saying explicitly in the commit message), if anyone is ever going to step over this commit.

damm 11y ago
That's a hard one; trying to make a single commit in a pull request helps me but sometimes even then a pull request gets ignored and they want me to rebase it. The problem is they ask /me/ to rebase it; I think they should take a little ownership in the potential rewriting of history.
- qu4z-2 11y ago
  There's no potential rewriting of history before they merge your pull request, only a series of unaccepted draft commits. :)