3 ms·

How to write the perfect pull request

18 points by daviducolo 11y ago

phaemon 11y ago
A little ironic to see this on github given: https://github.com/torvalds/linux/pull/17#issuecomment-5654674 https://github.com/torvalds/linux/pull/17#issuecomment-56546... But perhaps these issues have been fixed now?
- Sir_Cmpwn 11y ago
  Not everyone agrees with Linus. It's kind of silly to bring that up in a mostly unrelated thread about Github suggesting tips for working within their own PR system.
kpcyrd 11y ago
> Use emoji to clarify tone. Maybe it's just me, but I prefer my github issues not to look like a whatsapp conversation.
- meesterdude 11y ago
  I am the same way; I'm not a fan of trying to decipher what they mean; especially when there's no other text.
- lucb1e 11y ago
  > look like a whatsapp conversation. Even my personal/informal chats don't look that bad.
- yitchelle 11y ago
  who knows what the thousands of different emoji might mean in 12 months time.
a-dub 11y ago
I just wish that GitHub would hold onto force push history and produce diffs across them so they can be audited easily.
- Daviey 11y ago
  Or have an option to mark a project FF only, with a public statement how long this option has been switched on. Atlassian Stash has FF only as a config, and for most projects it makes quite a bit of sense!
lucb1e 11y ago
> Compare “:sparkles: :sparkles: Looks good :+1: :sparkles: :sparkles:” to “Looks good.” I see. Lesson learned: don't use emojis, it looks awful.
nzp 11y ago
Offering and Responding to feedback sections are so bad. Do people working at GitHub really need to basically be told to not be rude to each other, to give useful information and to be professional or at least fake politeness? Are they employing people in early teens with no socialization what so ever? Use emoji, what the hell?! “Our guidelines suit the way we work, and the culture we want to nurture. We hope you find them useful too. Happy communicating!” Ugh... What a weird place, and I don't mean this in a good way (taking into account all the previous workplace drama they had).

18 points by daviducolo 11y ago

A little ironic to see this on github given: https://github.com/torvalds/linux/pull/17#issuecomment-5654674 https://github.com/torvalds/linux/pull/17#issuecomment-56546... But perhaps these issues have been fixed now?

Sir_Cmpwn 11y ago
Not everyone agrees with Linus. It's kind of silly to bring that up in a mostly unrelated thread about Github suggesting tips for working within their own PR system.

kpcyrd 11y ago

> Use emoji to clarify tone. Maybe it's just me, but I prefer my github issues not to look like a whatsapp conversation.

meesterdude 11y ago
I am the same way; I'm not a fan of trying to decipher what they mean; especially when there's no other text.
lucb1e 11y ago
> look like a whatsapp conversation. Even my personal/informal chats don't look that bad.
yitchelle 11y ago
who knows what the thousands of different emoji might mean in 12 months time.

a-dub 11y ago

I just wish that GitHub would hold onto force push history and produce diffs across them so they can be audited easily.

Daviey 11y ago
Or have an option to mark a project FF only, with a public statement how long this option has been switched on. Atlassian Stash has FF only as a config, and for most projects it makes quite a bit of sense!

lucb1e 11y ago

> Compare “:sparkles: :sparkles: Looks good :+1: :sparkles: :sparkles:” to “Looks good.” I see. Lesson learned: don't use emojis, it looks awful.

nzp 11y ago

Offering and Responding to feedback sections are so bad. Do people working at GitHub really need to basically be told to not be rude to each other, to give useful information and to be professional or at least fake politeness? Are they employing people in early teens with no socialization what so ever? Use emoji, what the hell?! “Our guidelines suit the way we work, and the culture we want to nurture. We hope you find them useful too. Happy communicating!” Ugh... What a weird place, and I don't mean this in a good way (taking into account all the previous workplace drama they had).