6 ms·
I see these types of comments a lot and I do understand the logic of them. Most of the time it's devoid of sentiment. It's us engineers going "hey, there's a pr
by philjr 11y ago
I see these types of comments a lot and I do understand the logic of them. Most of the time it's devoid of sentiment. It's us engineers going "hey, there's a problem, this is the solution". This input causes this output. Problem? Open bug, assign to problem developer. I'm extremely sympathetic to it though as this would have been the way I dealt with this problem. Not only that but there's still a little bit of me that goes "yeah, right on! Shit code, shit coder! Make him clean up his own mess!"
The problem here is it's passive aggressive and doesn't actually communicate the issue to your colleague. The fact he's producing bad code probably isn't something he gets up to do every day.
The first part of any situation like this is clear communication. Talk to the person and you may have to do it dozens of times before it gets through. That doesn't mean the equivalent of throwing a bug report at him "Hey buddy, your code is shit. Fix it!"
He's a colleague. Sit down and talk through some of the code. Note your concerns and offer to help. Have clear and precise examples of your concerns, maybe presenting him with evidence. The first reaction any sane person is going to have if someone approached them like this is embarrassment and they're probably going to get a little defensive. Know that going in and tailor your conversation appropriately.
Enter in to the situation with some level of respect maybe even if that person hasn't really shown that he's deserved it.
Possibly, he'll never change, but I've seen enough people get better through coaching, mentoring and encouragement to know it's just as likely he'll make an effort if approached in the right way.
- stonemetal 11y agoI saw it more as mentoring by brick. Op has already tried to talk to the guy, but he keeps making the same mistakes. Teaching by example may help him to remember that certain constructs lead to certain issues because he has seen the bug reports, and how to handle them. Op is a contractor, not a life coach. I doubt his contract includes a large number of hours for mentoring. Maybe he could request them?
- philjr 11y agoEveryone should be a little bit of a life coach :-)