7 ms·
GitLab 7.11: 2FA, publicly viewable Enterprise Edition
- sytse 11y agoGitLab CEO here, we're very exited that we're able to open up the Enterprise Edition code and the 2 factor authentication.
- jordigh 11y agoI'm a bit amused: https://www.google.ca/?gws_rd=ssl#q=%22GitLab+ceo+here%22 https://www.google.ca/?gws_rd=ssl#q=%22GitLab+ceo+here%22 https://duckduckgo.com/?q=%22GitLab+CEO+here%22+site%3Anews.ycombinator.com&t=keywordsearch https://duckduckgo.com/?q=%22GitLab+CEO+here%22+site%3Anews....
- iancarroll 11y agoWhat's wrong with someone talking about their product?
- jordigh 11y agoThere's nothing wrong with it, just amusing.
- sytse 11y agoThe rest of the company team is now making fun of me on Slack due to this link :)
- ecnahc515 11y agoI wish more people would be upfront like you are. So often do I see really biased answers/responses on the internet, only to realize the person responding works for the company they're defending.
- sytse 11y agoThanks! We're having a company happy hour so I'll leave my response at this. Have a good weekend!
- paukiatwee 11y agoNot really related to topic, but how is GitLab CE & GitLab EE project maintained in term of source code? GitLab EE is fork of GitLab CE such that additional code of GitLab EE is in different directory (so upstream changes will not conflict with GitLab EE)?
- sytse 11y agoThanks for asking. GitLab CE and EE are different repo's. GitLab EE is a superset of the CE code. We merge CE into EE a couple of times per month. Sometimes changes in CE conflict with EE, the GitLab company team takes care of that. For more information please see https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/release/monthly.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/rele...
- Omnipresent 11y agoI love GitLab at our company but really want the keyboard shortcuts [1]. Especially the file finder [1] http://owenou.com/images/posts/github_shortcuts.png http://owenou.com/images/posts/github_shortcuts.png
- sytse 11y agoThere are keyboard shortcuts, see http://i.imgur.com/OSpOwT9.png http://i.imgur.com/OSpOwT9.png (press shift ? to view them) and if you miss any please add them.
- nadams 11y agoI've implemented 2FA for SVN and Mercurial (not yet for git) for Indefero. I highly recommend showing users the key for their storage - I've had to extract the keys from FreeOTP and Google Authenticator a number of times. How do you leverage 2FA with LDAP/AD accounts? Do you store/check the key in gitlab and then auth the users against LDAP/AD - or store the key in LDAP/AD?
- sytse 11y agoGitLab CEO here, I'm probably out of my depth and misunderstanding but let me try. I'll see if other people on my team can look into the question too. Instead of extracting keys don't you want to use backup codes (that we provide)? 2FA for LDAP accounts is an additional safety measure that you need to unlock the account. The key is stored in the same place as with non-LDAP account I think.
- nadams 11y ago> Instead of extracting keys don't you want to use backup codes (that we provide)? Perhaps my opinion is wrong - but if I replace my OTP generating device (such as my phone) I don't want to use recovery codes I just want to restore FreeOTP and be on my way. Recovery codes to me is "oh shit I need to get to my account right now because of some important reason X and I don't have my phone with me". To give you some background of why - I have about 20 OTP keys in FreeOTP right now - being able to have root access and restore FreeOTP from Titanium Backup is very important to me. This was particularly annoying when a service does not provide recovery codes. Or even worse (Symantec VIP OTP) they generate a random key generated based on the device - so even if you reinstall it you can't get the same key back (according to reviews in the play store - updates have even triggered a regen of keys) - locking people out of their accounts because many services who use Symantec VIP access don't offer recovery codes. This all goes back to the idea of exporting keys from apps like FreeOTP and Google auth. People have asked numerous times but no one wants to implement it in those applications (there is a 3rd party OTP app that claims to store the keys encrypted in dropbox...but last time I used it the automatic backup stopped working....). To make a long story short - if you present the QR Code I can get the key by using it a barcode scanner - but just tell me what it is so I can throw it in my password manager in the event I need to get into my account without my phone or have to replace my phone. We can talk offline if you are interested and I can explain how I do 2FA for SVN and Mercurial.
- mtsmith85 11y agoI love that GitLab has their code publically viewable. It provides another example of a large Rails application which is always useful as a way to "see how other people approach challenges" as well as my favorite "why the heck doesn't this work" problems that surface when implementing CI/RSpec, etc.
- sytse 11y agoThanks! Apart from code we're starting to make almost all of our internal procedures public too, we started with https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/release/monthly.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/rele... did https://about.gitlab.com/handbook/ https://about.gitlab.com/handbook/ a month ago and are now working on support, sales, onboarding and other processes.
- m4tthumphrey 11y agoLovely! Congrats Sytse, Dimitry and co! Will be upgrading next week. As a long time user (nearly 3 years now), it really is amazing that you guys manage to release dead on the 22nd EVERY month and always with new features! Amazing.
- jobvandervoort 11y agoThanks, that's great to hear. Actually, our release cycle is open source as well[1], so you can see EXACTLY how we do it every month ;-) [1] https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/release/monthly.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/rele...
- mikegerwitz 11y agoAnother positive development with Gitlab EE is that its client-side JavaScript and all code that generates or is compiled into it is Expat-licensed: https://about.gitlab.com/2015/05/20/gitlab-gitorious-free-software/
- sytse 11y agoThanks to you Mike! <3
- bau5 11y agoIf someone forks CE and adds features missing in CE but present in EE, will GitLab accuse them of looking at the EE code and violating the license? Will that accusation stick? It will be interesting to see. BTW I hate the open core model. http://en.wikipedia.org/wiki/Open_core http://en.wikipedia.org/wiki/Open_core
- sytse 11y agoOpen core is a double edge sword, but we try to enlarge the advantages (resources to do release management, fix bugs, upgrade dependencies, investigate security reports) and minimize the downsides (no artificial limits in CE, no crippleware). Looking at the EE code is fine but you can't use the code. So merge requests that add EE code into CE will not be accepted.
- akerl_ 11y agoThe point being made above seems to be "Releasing the source for EE poisons dev efforts", because if I fork CE and add code that does something EE adds, GitLab might claim that I "stole" code from EE, or looked at EE and was tainted with knowledge from EE code. Even if I hadn't copied code from EE, the claim could be made and would be destructive to the ability of community members to fork and improve the open source codebase
- sytse 11y agoI expect that in most cases we'll be able to tell from the code. In cases where we can't tell we assume that people made it themselves. We are releasing the code to make EE easier to work with (having private repos and docker images is hard). We did not want to make it harder to contribute EE features to CE. If people are worried about poisoning please let me know. Merging EE functions into CE has always been at the discretion of the core team, we don't need any excuses.
- geofft 11y agoThat is super cool. Thank you for demonstrating that it's possible to be a CEO of a successful, community-friendly proprietary version-control company without turning into Larry McVoy.
- philtar 11y agoCurious: Does gitlab support really large files?
- sytse 11y agoYes, via Git Annex https://about.gitlab.com/2015/02/17/gitlab-annex-solves-the-problem-of-versioning-large-binaries-with-git/ https://about.gitlab.com/2015/02/17/gitlab-annex-solves-the-... (we'll soon release a patch release to fix a problem with it in 7.10.x)
- kaolinite 11y agoI recently switched from Github to Gitlab (although only for private projects). In the past I'd used Bitbucket but I disliked the interface. Gitlab, on the other hand, is much better. I think overall I still prefer Github, but it's nice to have unlimited private repos and Gitlab is approaching being as good. It's a remarkably polished project.
- sytse 11y agoThanks for your kind words Tim! We are happy to offer everyone unlimited private repos on GitLab.com https://about.gitlab.com/gitlab-com/ https://about.gitlab.com/gitlab-com/ What can we improve so you would prefer GitLab over GitHub?
- kaolinite 11y agoWait, really? Oh. I host it myself, I figured it'd cost for private repos at GitLab.com. Probably should have checked that :-) Regarding improvements, I don't really have any specific examples. Just keep at it and I'm sure that, over time, you'll refine it until it's perfect. It's really great as it is.
- sytse 11y agoOK, thanks for your response!
- darklajid 11y agoSomething I consider for quite a while: Would it be possible to use GitLab as a 'frontend' only? With remote repositories? I ask, because our company recently killed of a Gitorious instance that worked fine for ~5 years, to 'upgrade' us to TFS and there are quite some .. issues and limitations with that idea. Looking for a way to make IT happy ('yes, code is stored in TFS') and keep a usable/productive environment.
- sytse 11y agoI'm sorry but that is not possible. You would have to use scripts to mirror the repos https://github.com/samrocketman/gitlab-mirrors https://github.com/samrocketman/gitlab-mirrors but we don't recommend it.
- darklajid 11y agoThanks a lot for the 'official' answer. Appreciated, not unexpected, but sad. Actually that link DOES look quite interesting..
- sytse 11y agoDon't do it! :)
- darklajid 11y agoOr else? ;-) Frankly, I'm torn and might spin up a test instance on Monday (it's a day off here) to give it a try. Can't do jack about TFS hosting the sources, but anything that gives me a saner/better interface and usable issues etc. on top would be .. awesome.
- sytse 11y agoOK, go for it :)
- btmiller 11y agoAwesome! I really like using Gitlab CE. Are there any plans for more code review type enhancements? We typically do lots of discussion on merge requests and often times, certain code features or plans will get scheduled for a refactor sometime in the future. Though, all those comments kinda get hidden away after the branch is merged. Maybe what I should be doing is using the Wiki, but it would be nice to be able to leave comments on the HEAD (i.e. comments on current state of a project).
- sytse 11y agoGood to hear you like GitLab. We don't have any plans for code review improvements at the moment. Your proposal sounds interesting. We normally try to refactor the code before merging the merge request. If there are any loose ends we make an issue out of it.
- pserwylo 11y agoWhile I am not against rapid UI evolution, as seems to be the case with GitLab, I think you may want to revise the choice of background vs text colour on the sidebar. It does look pretty, but the WCAG guidelines describe a minimum level of contrast for people with vision imparement to be able to read well. This side bar has a very low level of contrast, and putting the URL of a GitLab project into various WCAG evaluatioin tools will tell you the same. Having said that, thank you for GitLab. Even though this post is about the Enterprise Edition, it is good to see some high quality open source alternatives to GitHub (i.e. the Community Version). We moved F-Droid there and have had mostly a very positive experience.
- sytse 11y agoThanks for moving F-Droid to GitLab.com, we appreciate it. You can change the colors of the sidebar on /profile/design I'm not sure if any other choices improve the contrast. Feel free to submit a design that meets WCAG guidelines.