3 ms·

Looks fun. A couple of minor comments: * The copystring() function looks like you re-implemented strdup() from string.h. * The call to malloc() followed by a

by pjscott 11y ago

Looks fun. A couple of minor comments: * The copystring() function looks like you re-implemented strdup() from string.h. * The call to malloc() followed by a call to memset() to zero it can be replaced with a call to calloc(). This is faster on some platforms, and makes for cleaner code.

infradig 11y ago
Because strdup() is not standard enough to rely on. You have to test all sorts of magic values to pull it in, then you have define it yourself for those cases where it isn't defined. Why bother? Just write you own equivalent.
- cperciva 11y ago
  If you're not running on POSIX.1-2001, you're not likely to have pthreads or GCC builtin functions.
  - infradig 11y ago
    If you specify -std=c11 you won't get strdup().
watmough 11y ago
Cool, thanks for the comments.