3 ms·
I'm not usually a guy that asks for a code review to be done directly by pinging the reviewers, but I've found on certain projects there are colleagues who will
by roskilli 11y ago
I'm not usually a guy that asks for a code review to be done directly by pinging the reviewers, but I've found on certain projects there are colleagues who will unfortunately _never_ review any diffs I have with them listed even as the sole reviewers until I ask them.
This is unfortunate but means that I fall behind by however long I don't ask them to review my code for :( Others are great and I don't have to ping them directly and they can tell how urgent a review is or isn't usually.
Not commenting specifically on any situations discussed here but just realizing I do sit on the other side of the fence from time to time.
- ohitsdom 11y agoGood point. I certainly have a long backlog of changes waiting for review from others. I suspect that's more of a flaw in my current job's review process though. I do think there's plenty of room to ping colleagues with a "hey, don't forget about that code review" before you become the "stop what you're doing and look at my code" guy.