5 ms·

Did I read the number wrong, or is that an absurd amount of changes (note: I haven't look at the commit myself, as I have no idea how to get all the stats from

by NhanH 11y ago

Did I read the number wrong, or is that an absurd amount of changes (note: I haven't look at the commit myself, as I have no idea how to get all the stats from github interface)? That's about 800000 additional lines of code for 49 developers in a months, or ~16000 LOC for each developer. Unless additions and deletions are counted on a different unit, can anyone knowledgeable explain to me how the numbers are reasonable at all?

frutiger 11y ago
Unless you ask it, git considers file moves to be a complete deletion of the file along with the addition of the file. A good way to tell git to detect renames is to use the similarity flags: `git diff -M60% --shortstat` will consider files 60% similar to be renames.
deleted 11y ago
[deleted]
lugg 11y ago
Most of it is junk find and replace stuff / formatting docs etc. [1] Pulse [2] is just a neat github feature that gives you an overview of a project. LOC will always be a shitty metric for anything. [1] https://github.com/iojs/io.js/commit/56e4255382ad4d2426e034624b41bbe97d18bca0 https://github.com/iojs/io.js/commit/56e4255382ad4d2426e0346... [2] https://github.com/iojs/io.js/pulse https://github.com/iojs/io.js/pulse
deleted 11y ago
[deleted]
brandonb927 11y ago
Joyent used to have the license on the top of virtually EVERY file in the repo for node. Someone removed all but one (6430 deletions) https://github.com/iojs/io.js/pull/311/files https://github.com/iojs/io.js/pull/311/files I can imagine this makes up for a portion of it.
- tiles 11y ago
  Not just someone, but @izs (former maintainer, creator and current co-founder of NPM)
- riffraff 11y ago
  I remember this was a common thing in free/open source projects some time ago[0]. At some point people started to believe that this was not necessary. I am not sure of the legal implications, of either choice, just wanted to point out that the joyent people probably were not crazy :) [0] e.g. a random file from ISC bind https://source.isc.org/git/?p=bind9.git;a=blob;f=bin/rndc/rndc.c;h=150a4ea0882743fc50d33d42c180f94d7e1d4915;hb=ecaed3593cd14f2491d1bd81fc98cb940e12f8bb https://source.isc.org/git/?p=bind9.git;a=blob;f=bin/rndc/rn...
  - vidarh 11y ago
    In every Berne Convention signatory country (which is pretty much any country that will matter to most people), published works are required by the convention to be copyrighted by default, whether or not there is a copyright notice, and the lack of a license means you have to assume you have none unless something else tells you differently. That basically makes embedding the license text pointless. It certainly was common, though, which is/was probably because the US did not join until 1989, and prior to that US copyright law required a mandatory copyright notice, so a lot of people will have at least worked on projects old enough for this policy to have mattered.
    - greggman 11y ago
      Really? I've been putting the license in every file in my project because it's JavaScript and people drive by a website, see "foo.js" and have no idea where it came from or what license it's under. With the license in the file it's immediately clear.
      - towelguy 11y ago
        If the file doesn't have a copyright notice, I'd assume the author is the website's owner and its license should apply. Maybe there should be a convention to add a copyright.txt file to websites like there is robots.txt and humans.txt?

by NhanH 11y ago

frutiger 11y ago

Unless you ask it, git considers file moves to be a complete deletion of the file along with the addition of the file. A good way to tell git to detect renames is to use the similarity flags: `git diff -M60% --shortstat` will consider files 60% similar to be renames.

deleted 11y ago

[deleted]

lugg 11y ago

Most of it is junk find and replace stuff / formatting docs etc. [1] Pulse [2] is just a neat github feature that gives you an overview of a project. LOC will always be a shitty metric for anything. [1] https://github.com/iojs/io.js/commit/56e4255382ad4d2426e034624b41bbe97d18bca0 https://github.com/iojs/io.js/commit/56e4255382ad4d2426e0346... [2] https://github.com/iojs/io.js/pulse https://github.com/iojs/io.js/pulse

deleted 11y ago

[deleted]

brandonb927 11y ago

Joyent used to have the license on the top of virtually EVERY file in the repo for node. Someone removed all but one (6430 deletions) https://github.com/iojs/io.js/pull/311/files https://github.com/iojs/io.js/pull/311/files I can imagine this makes up for a portion of it.

tiles 11y ago
Not just someone, but @izs (former maintainer, creator and current co-founder of NPM)
riffraff 11y ago
I remember this was a common thing in free/open source projects some time ago[0]. At some point people started to believe that this was not necessary. I am not sure of the legal implications, of either choice, just wanted to point out that the joyent people probably were not crazy :) [0] e.g. a random file from ISC bind https://source.isc.org/git/?p=bind9.git;a=blob;f=bin/rndc/rndc.c;h=150a4ea0882743fc50d33d42c180f94d7e1d4915;hb=ecaed3593cd14f2491d1bd81fc98cb940e12f8bb https://source.isc.org/git/?p=bind9.git;a=blob;f=bin/rndc/rn...
- vidarh 11y ago
  In every Berne Convention signatory country (which is pretty much any country that will matter to most people), published works are required by the convention to be copyrighted by default, whether or not there is a copyright notice, and the lack of a license means you have to assume you have none unless something else tells you differently. That basically makes embedding the license text pointless. It certainly was common, though, which is/was probably because the US did not join until 1989, and prior to that US copyright law required a mandatory copyright notice, so a lot of people will have at least worked on projects old enough for this policy to have mattered.
  - greggman 11y ago
    Really? I've been putting the license in every file in my project because it's JavaScript and people drive by a website, see "foo.js" and have no idea where it came from or what license it's under. With the license in the file it's immediately clear.
    - towelguy 11y ago
      If the file doesn't have a copyright notice, I'd assume the author is the website's owner and its license should apply. Maybe there should be a convention to add a copyright.txt file to websites like there is robots.txt and humans.txt?