3 ms·
"Reprove with sharpness, then show afterwards an increase of love." Telling a coder he needs to break down a function and get rid of deeply nested function isn
by swsieber 12y ago
"Reprove with sharpness, then show afterwards an increase of love."
Telling a coder he needs to break down a function and get rid of deeply nested function isn't calling it crap, it's giving him a way forward to improve his code. As a new hire, he deserves that feedback. If he follows it, compliment him and give positive feedback.
Whether a person can become a good coder isn't determined by how he writes code, it's how he reacts to the feedback he gets. If he can take correction, he can become a good coder.
- sarciszewski 12y ago> Whether a person can become a good coder isn't determined by how he writes code, it's how he reacts to the feedback he gets. Quoted for emphasis. My first recursive postgresql function was crap. I recently learned that it became a DoS vector at 3 layers deep because I had horribly flawed logic. I spent an hour the other night refactoring it. The cruelest feedback comes not from mortals, but from the harsh production environments which do not tell you what is wrong, but merely go offline.