3 ms·
Reject the pull request, but be civil about it. Explain what is wrong with the code and give some pointers for fixing it. I suggest you do this in person. Reje
by johan_larson 12y ago
Reject the pull request, but be civil about it. Explain what is wrong with the code and give some pointers for fixing it.
I suggest you do this in person. Rejecting someone's work can easy come across as maligning their skills in general, particularly in print. It will be easier to make the distinction face to face. This will also allow for more discussion of what changes are needed, if your coworker has questions.