3 ms·
+1 Fantastic. Its hard to receive these reviews as a young engineer, and as a slightly more experienced engineer, it is also hard to give them. But its an impor
by fndrplayer13 11y ago
+1 Fantastic. Its hard to receive these reviews as a young engineer, and as a slightly more experienced engineer, it is also hard to give them. But its an important part of the job. Its fine, in my opinion, to give the hard review, as long as you walk over to your coworkers desk, and helpfully guide them through this as a learning experience. Having this stuff written down is also helpful for them to reason.
That being said, I dont think I'd ever say, "This code sucks." I might say something like "I think there is significant room for improvement here if you were to <xyz>"
- rancur 11y agoroom for improvement is still pointing out the failure to hit the mark. Much better to stay focused on positives in code, like you focus on the positives in a relationship. 'I wish you would...' is so much different from 'stop doing XYZ, it annoys me' I have only barely begun to understand let alone implement the relationship side, so I'm sorry I don't have more examples of how to handle this in code review.