4 ms·
I work with a lot of contractors and so I end up doing this frequently. Here's the pattern I follow: 1. Reject the PR. It needs to be clear that this isn't acc
by vkjv 11y ago
I work with a lot of contractors and so I end up doing this frequently. Here's the pattern I follow:
1. Reject the PR. It needs to be clear that this isn't acceptable.
2. Realize that stopping with rejection doesn't help the problem at all. :)
3. Start with some light comments and refactoring a couple of sections (usually it's the same bad patterns repeated).
4. Only provide the refactors as comments. Try not to fix other people's PR and then submit. It makes it hard for that person to improve.
5. Talk with the individual about it. Ask about the issues they were having and offer fixes.
6. Ask them to try again.
If this cycle happens a few times, you either need to break down tasks into simpler, smaller bites, or let them go. This can quickly turn into negative productivity for the team.