5 ms·
It's worth noting: https://github.com/mholt/caddy/blob/master/server/server.go https://github.com/mholt/caddy/blob/master/server/server.go That the actual web
by buro9 12y ago
It's worth noting:
https://github.com/mholt/caddy/blob/master/server/server.go https://github.com/mholt/caddy/blob/master/server/server.go
That the actual web server in use is:
https://github.com/bradfitz/http2 https://github.com/bradfitz/http2
Which isn't to detract from the Caddy project which offers a tidy set of configuration options so that the lib is more like an Nginx executable with config files.
Perhaps the README can be updated though, as "Caddy binaries are available for nearly every platform and has no dependencies" is a bit misleading. The binary produced by Go may not have dependencies, but the Go code itself has a few large dependencies.
- mholt 12y agoThat's a good way to describe it, I was having trouble explaining that succinctly on my own! And I will update the project on GitHub to give due credit to libraries utilized.
- buro9 12y agoSeriously impressed with the amount of work you've put into it... I didn't want to otherwise detract from your work, but it is a good idea to declare which 3rd party dependencies do exist just so that anyone forking it can be aware of this and ensure that they vendor it (using whatever their preferred method is). I'd probably opt to change the phrasing to be clear that you're using these other libs, simply because they are well-proven, have a lot of mindshare, and that you're standing on the shoulders of giants and bringing it all together in an out-of-the-box server that people can immediately use is actually a great story.
- jfolkins 12y agobradfitz's http2 package will be rolled into Go's core upon completion so I don't feel it is at all inappropriate for Matt to state "No Dependencies."
- devalnor 12y agoThey also streamed it: https://www.youtube.com/watch?v=yG-UaBJXZ80 https://www.youtube.com/watch?v=yG-UaBJXZ80
- mmgutz 12y agoI also had the impression this was some new web server when Caddy seems to be configuration glue of a WIP HTTP/2 server and external packages.
- jfolkins 12y agoI see what you mean. That is a fair point.