3 ms·
This looks like a poor clone of http://landscape.io/ http://landscape.io/ - viewing what they have to offer on github, I'm not very impressed at all, the intern
by jquast 11y ago
This looks like a poor clone of http://landscape.io/ http://landscape.io/ - viewing what they have to offer on github, I'm not very impressed at all, the internal tool of landscape.io, https://github.com/landscapeio/prospector https://github.com/landscapeio/prospector does a whole lot more.
I think calling it "code review" as opposed to "health" or just "lint checker" is marketing bullshit aimed at managers who think all work of engineers could be magically boiled down to automation.
That said, I make heavy use of prospector, along with or wrapping: dodgy, frosted, mccabe, pep257, pep8, pylint, pyroma, restructuredtext_lint, doc8, and sphinx-build "warnings as errors" as part of my builds.
Result: Code that becomes a public source reference used by other projects. Contributions from people who are able to quickly dive in and find where to place the change they wish to propose. Through enforced styling, the entire codebase reads as though it has a single authorship, "same throughout", this can make ~5K LOC as easy to adapt to as another of 1/10th its size.
I took a ~25K LOC open source project, ran it through landscape.io, worked (along with closing many other bugs) from "50% health" towards "97% health", and the readability and maintainability of the project increased drastically. It does work.
Why are these checkers useful? Because I want people who review code, especially in business, to spend their time on the purpose of the code, and not spend a single minute of their time considering whether this suites the "style" of their engineering department. I have seen too many people use code review for pedantic styling.
If I can have the tools reject the code before a person, it lowers the time/cost of a purposeful review. It also hurts less ego's to get only 1 or 2 open issues as opposed to 15-20.
Crude napkin estimates of current and past employers gauge the value of the software at roughly $10-$25 per line of code. It should be treated as such.
- geoelectric 11y agoI'd be interested in reading any blog posts you have about your validation stack!
- ThePhysicist 11y agoThanks for the feedback! Compared to landscape.io (or other tools) we have a different approach to code checking since we develop our own algorithms and even allow our users to create custom code checks using a code pattern language (http://docs.quantifiedcode.com/patterns/language/index.html http://docs.quantifiedcode.com/patterns/language/index.html) landscape.io is a great tool of course (in fact we've been in touch with Carl since a while) but we really wanted to go in a different direction with this and build a tool that goes beyond providing a simple frontend to existing tools. The current beta of QuantifiedCode is of course just the beginning and does lack many features that we're currently working on (e.g. giving the user access to the graph representation of code that we use internally), so stay tuned for more. BTW we have open-sourced our own "Prospector"-like tool, checkmate (https://github.com/quantifiedcode/checkmate https://github.com/quantifiedcode/checkmate). Right now it's still in beta though and we don't pursue it very actively since we use mainly our graph-based approach to code analysis now (so we don't need to aggregate output from different tools).
- jquast 11y agoI did look at checkmate. It was my mistake in believing this was the total sum of the checker used in quantifiedcode. One problem I have with such monetary solutions is that in business where I am willing to pay, I could not provide a SaaS tool like codechecker access to the enterprise github hosted on an internal network (or possibly some other repository service). I'd be happy to pay, but it just isn't technically feasible unless there is a self-hosting solution, which complicates things for you beyond what is profitable: I don't know what the solution is, but this is why I use only cmd-line tools like prospector in business, rather than simply paying for landscape.io or codechecker. I'll stay tuned, thanks for responding.