3 ms·

I'm not a fan of pre-commit hooks (as I'd rather write it, lint it, fix-rebase-it), but I love having a CI suite that includes the linting tests that our team h

by gknoy 12y ago

I'm not a fan of pre-commit hooks (as I'd rather write it, lint it, fix-rebase-it), but I love having a CI suite that includes the linting tests that our team has agreed on. It lets me code away and lint things when I'm ready to make my pull requests.

jquast 12y ago
agreed, git hooks are a terrible place, they can actually impede progress and can also be skipped/disabled/never installed in the first place. The time for rejecting a build for linting is at time of merge to trunk/next release, which a good CI should already have checked.
ThePhysicist 12y ago
yeah that's the workflow we have in mind as well: -make changes in a feature branch -have the linter run on each commit to see if there are problems -when you make a pull request, check the code again and comment on the PR if there are any problems.