4 ms·
I think you also miss that the reason the "file" got the attention were the recent fuzzing actions. Which discovered the bugs obviously not present in the quote
by acqq 12y ago
I think you also miss that the reason the "file" got the attention were the recent fuzzing actions. Which discovered the bugs obviously not present in the quoted 6 year old tests. Otherwise there would be no discovery at all.
So no, the 6-year tests weren't sufficient. And yes, the updated tests and fixed old implementation is more important step than ""this time it will be done right", ha ha"
Additionally, replacing the "defined" constants from the file.h with the enum in another .h is hardly a reason for the rewrite.
- nossabova 12y agoI think I understand your point better now. More thorough tests in addition to the current set would certainly be an improvement. However, I don't understand why you suggest that fixing the old implementation to adhere to new programming standards would be better than re-writing the program from scratch, because most of the program would have to be re-written anyways, and so the developer would barely save any time and effort by fixing rather than re-writing. Also, if more thorough tests were to be included, then either fixing the program or re-writing it would have the same impact security-wise, as the improved tests would account for any discrepancy in either route. IMO, in this case, whether to fix the old software or to re-write a new version were both acceptable options.
- acqq 12y agoI neither suggest anything like "fixing the old implementation to adhere to new programming standards" nor "re-writing the program from scratch." I suggest extending the tests, fixing the problems discovered in the existing implementation and then doing something completely new, somewhere else.