5 ms·

Magento code in general is of very dubious quality. I once ran a quick static analysis on it and found some ridiculous results: https://twitter.com/jlas_/status

by jlas 11y ago

Magento code in general is of very dubious quality. I once ran a quick static analysis on it and found some ridiculous results: https://twitter.com/jlas_/status/391615992473722880 https://twitter.com/jlas_/status/391615992473722880

mrweasel 11y ago
That's somewhat terrifying
mahouse 11y ago
Sorry, but what is that tool?
- jlas 11y ago
  It was a while ago but I think it was PHPMD: http://phpmd.org/rules/codesize.html http://phpmd.org/rules/codesize.html
Someone1234 11y ago
While it could be better written, that's just their installer, it doesn't run in production by its very nature so might be a low priority for coding standards. If you wanted to call them out, at least call them out for something which actually runs during normal operation.
- davidgerard 11y ago
  Whoever wrote Magento thinks 777 permissions are ever the right thing to do. Every book I've ever seen on Magento seems to think the same. That 777 permissions are just not a big deal.
  - benmarks 11y ago
    From http://devdocs.magento.com/guides/m1x/install/installer-privileges_before.html http://devdocs.magento.com/guides/m1x/install/installer-priv... : "All directories have 700 permissions (drwx------). 700 permissions give full control (that is, read/write/execute) to the owner and no permissions to anyone else. "All files have 600 permissions (-rw-------)."
    - davidgerard 11y ago
      From the Magento Enterprise tarball, which we pay enormous sums of money for: https://news.ycombinator.com/item?id=9417235 https://news.ycombinator.com/item?id=9417235
DCoder 11y ago
I just ran PHPStorm's inspections on Magento's core code: http://imgur.com/RMxWEgR http://imgur.com/RMxWEgR Granted, the tool I used is opinionated and not all those items are red flags, but the sheer number of issues is impressive.

5 ms·

Magento code in general is of very dubious quality. I once ran a quick static analysis on it and found some ridiculous results: https://twitter.com/jlas_/status

by jlas 11y ago

mrweasel 11y ago
That's somewhat terrifying
mahouse 11y ago
Sorry, but what is that tool?
- jlas 11y ago
  It was a while ago but I think it was PHPMD: http://phpmd.org/rules/codesize.html http://phpmd.org/rules/codesize.html
Someone1234 11y ago
While it could be better written, that's just their installer, it doesn't run in production by its very nature so might be a low priority for coding standards. If you wanted to call them out, at least call them out for something which actually runs during normal operation.
- davidgerard 11y ago
  Whoever wrote Magento thinks 777 permissions are ever the right thing to do. Every book I've ever seen on Magento seems to think the same. That 777 permissions are just not a big deal.
  - benmarks 11y ago
    From http://devdocs.magento.com/guides/m1x/install/installer-privileges_before.html http://devdocs.magento.com/guides/m1x/install/installer-priv... : "All directories have 700 permissions (drwx------). 700 permissions give full control (that is, read/write/execute) to the owner and no permissions to anyone else. "All files have 600 permissions (-rw-------)."
    - davidgerard 11y ago
      From the Magento Enterprise tarball, which we pay enormous sums of money for: https://news.ycombinator.com/item?id=9417235 https://news.ycombinator.com/item?id=9417235
DCoder 11y ago
I just ran PHPStorm's inspections on Magento's core code: http://imgur.com/RMxWEgR http://imgur.com/RMxWEgR Granted, the tool I used is opinionated and not all those items are red flags, but the sheer number of issues is impressive.