3 ms·
"Four lines of code" tells us nothing. How many users did that change impact? And was it likely to be noticed by end users and in need of justification? Is it l
by Someone1234 12y ago
"Four lines of code" tells us nothing. How many users did that change impact? And was it likely to be noticed by end users and in need of justification? Is it likely to lose Google revenue if it went south?
For example, it might take just "four lines of code" to change the Chrome's SSL padlock into a smiley face, but that would be a significant change, that would require hundreds of training docs' to be updated, and potentially re-training of end users.
- yid 12y agoI'm sure OP understands that four lines of code can be important. I think it was just different from what they were used to at the early stages of the company, where there was perhaps less oversight of engineers. Oversight is necessary at a company the size of today's Google, but it's also possible to be over-encumbered by bureaucracy.
- magicalist 12y agoJust based on human-hours per line of code alone, that level of oversight isn't possible to maintain over that large of a codebase, so it seems impossible for that to be the regular case. More likely it's highly dependent on where that code is, your exact manager chain, etc. It could just as easily be that you picked the week a new manager started or a new process was put in place that turned out to be terrible and was so rolled back.
- yid 12y ago> More likely it's highly dependent on where that code is, your exact manager chain, etc. It could just as easily be that you picked the week a new manager started or a new process was put in place that turned out to be terrible and was so rolled back. Absolutely. There are many good and valid reasons. The net result though is the same in terms of the impact to GP's personal productivity. People tolerate bureaucracy to different degrees, and it's a personal balance for everyone.
- technofiend 12y agoOne line of code, six months of process. But it was code in the module that computed stress on the space shuttle's interconnects between the orbiter and its tanks during launch. The six months of process was the minimum and all I wanted to change was a goto, eliminating a dead code branch. I can't even imagine if I had tried to make deeper changes. Having said that, there have been times when I wished Google had a process that would keep some of their odder mistakes from happening. Most recently the android calendar client changes. No month view, really? The amount of review you mentioned could be excessive or just the minimum because the entire product was sensitive or high risk. With no context it's hard for us to judge.