4 ms·

I couldn't help but notice this slightly, uh, controversial part of the codebase: https://github.com/sloisel/numeric/blob/656fa1254be540f428710738ca9c153962577

• kbenson 12y ago
  One can always hope they aren't using it's more recent social definition. delay or hold back in terms of progress, development, or accomplishment
  • bshimmin 12y ago
    That seems a little overly charitable, given the context... It appears to be checking whether the browser is Internet Explorer, and creating a Web Worker polyfill if it is - which, naming conventions aside, really isn't such a good strategy. There's also a lot of `var foo` in that file; I don't know if it says much about the quality of code in the rest of the project (maybe this is just a file slapped together in a hurry), but it doesn't particularly inspire confidence. In fact, on closer investigation, there's a lot of `var foo` in this file too: https://github.com/sloisel/numeric/blob/master/src/numeric.js https://github.com/sloisel/numeric/blob/master/src/numeric.j...
• Gurkenmaster 12y ago
  That won't work since IE11 because it no longer contains IE or MSIE in the useragent.
  • frik 12y ago
    Yes, but Numeric works fine in IE11 anyway. The IE11 user agent looks like this: Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko