4 ms·

This is not monkey patching. This is the good old function/api "hooking" that's pretty common in the compiled language world: http://en.wikipedia.org/wiki/Hooki

This is not monkey patching. This is the good old function/api "hooking" that's pretty common in the compiled language world: http://en.wikipedia.org/wiki/Hooking http://en.wikipedia.org/wiki/Hooking Monkey patching is a less invasive version of hooking used in dynamic languages. Bottom line: if you are dealing with assembly it's no longer monkey patching :-)

bouk 12y ago
There's not really anything equivalent in the Go world right now so I chose to just adopt the Ruby/Python term :) It kind fits in with what Wikipedia describes as monkey patching http://en.wikipedia.org/wiki/Monkey_patch http://en.wikipedia.org/wiki/Monkey_patch
- kylequest 12y ago
  Except the wiki page about monkey patching talks about it in the context of dynamic languages :-) It doesn't talk about C, C++ or other compiled languages. Definitely nice work!
  - simscitizen 12y ago
    Dynamic and compiled are not mutually exclusive. Objective-C is both a dynamic and compiled (to machine code) language that supports monkey patching. It supports extending classes with new methods and overriding existing methods in existing classes through its category feature. This does have an unfortunate side effect though. Because Objective-C is a) compiled directly to machine code b) has no way of marking methods final and c) supports monkey patching, essentially no methods can be inlined by the compiler.
    - kylequest 12y ago
      Of course, dynamic and compiled are not mutually exclusive. Go is not like Objective-C though and it doesn't support "Categories" or "extension methods" :)
tptacek 12y ago
I feel like I'm pretty familiar with "monkey patching" as practiced in Rubyland, and I'm a systems C programmer from the 90s. Can you help me understand the distinction you're drawing here? I don't have an understanding of "monkey patching" that involves how "invasive" it is; in fact, a repeated complaint about Ruby is how uninvasive it makes monkey patches, since the very concept of monkey patching breaks assumptions other programmers might rely on it.
- haberman 12y ago
  I think the important distinction is that Ruby/Python monkey-patching work within the defined semantics of the language, whereas this is targeting implementation-specific details of one particular runtime.
  - tedunangst 12y ago
    At the end of the day however, it's still patching code you don't own. Doesn't the term strongly imply modifications outside the scope of the author's intentions? Even in ruby and python, monkey patching is rarely the documented means to modify a library's behavior.
  - zurn 12y ago
    Hooking is also is widely used for a "call this function before doing x" type extension API. Eg. https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html https://www.gnu.org/software/emacs/manual/html_node/elisp/Ho... https://api.drupal.org/api/drupal/includes%21module.inc/group/hooks/7 https://api.drupal.org/api/drupal/includes%21module.inc/grou... https://msdn.microsoft.com/en-us/library/windows/desktop/ms632589%28v=vs.85%29.aspx https://msdn.microsoft.com/en-us/library/windows/desktop/ms6...
- kylequest 12y ago
  Yes, monkey patching is pretty uninvasive. It's a better way to describe it. It's a "feature" supported by a dynamic language. Still, unexpected things can happen if something is patched multiple times though it's easy to track and fix :) Monkey patching ends and hooking begins when you go outside of what's provided by the language digging into assembly and byte code.

bouk 12y ago

There's not really anything equivalent in the Go world right now so I chose to just adopt the Ruby/Python term :) It kind fits in with what Wikipedia describes as monkey patching http://en.wikipedia.org/wiki/Monkey_patch http://en.wikipedia.org/wiki/Monkey_patch

kylequest 12y ago
Except the wiki page about monkey patching talks about it in the context of dynamic languages :-) It doesn't talk about C, C++ or other compiled languages. Definitely nice work!
- simscitizen 12y ago
  Dynamic and compiled are not mutually exclusive. Objective-C is both a dynamic and compiled (to machine code) language that supports monkey patching. It supports extending classes with new methods and overriding existing methods in existing classes through its category feature. This does have an unfortunate side effect though. Because Objective-C is a) compiled directly to machine code b) has no way of marking methods final and c) supports monkey patching, essentially no methods can be inlined by the compiler.
  - kylequest 12y ago
    Of course, dynamic and compiled are not mutually exclusive. Go is not like Objective-C though and it doesn't support "Categories" or "extension methods" :)

tptacek 12y ago

I feel like I'm pretty familiar with "monkey patching" as practiced in Rubyland, and I'm a systems C programmer from the 90s. Can you help me understand the distinction you're drawing here? I don't have an understanding of "monkey patching" that involves how "invasive" it is; in fact, a repeated complaint about Ruby is how uninvasive it makes monkey patches, since the very concept of monkey patching breaks assumptions other programmers might rely on it.

haberman 12y ago
I think the important distinction is that Ruby/Python monkey-patching work within the defined semantics of the language, whereas this is targeting implementation-specific details of one particular runtime.
- tedunangst 12y ago
  At the end of the day however, it's still patching code you don't own. Doesn't the term strongly imply modifications outside the scope of the author's intentions? Even in ruby and python, monkey patching is rarely the documented means to modify a library's behavior.
- zurn 12y ago
  Hooking is also is widely used for a "call this function before doing x" type extension API. Eg. https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html https://www.gnu.org/software/emacs/manual/html_node/elisp/Ho... https://api.drupal.org/api/drupal/includes%21module.inc/group/hooks/7 https://api.drupal.org/api/drupal/includes%21module.inc/grou... https://msdn.microsoft.com/en-us/library/windows/desktop/ms632589%28v=vs.85%29.aspx https://msdn.microsoft.com/en-us/library/windows/desktop/ms6...
kylequest 12y ago
Yes, monkey patching is pretty uninvasive. It's a better way to describe it. It's a "feature" supported by a dynamic language. Still, unexpected things can happen if something is patched multiple times though it's easy to track and fix :) Monkey patching ends and hooking begins when you go outside of what's provided by the language digging into assembly and byte code.