3 ms·
I think GitHub should have added a more descriptive error message (since they control it thanks to how the attack vector works). alert( "The site you
by akx 12y ago
I think GitHub should have added a more descriptive error message (since they control it thanks to how the attack vector works).
alert(
"The site you are visiting contains malicious JavaScript.\n" +
"Your computer is currently being used to attack Github.com."
)
or something...
- arcatek 12y agoAnd let's add some taunt in it: "[...] Github.com, and more specifically the tools allowing to easily bypass the chinese government censorship." I wonder what would happen with such a message.
- Rezo 12y agoThe only thing the average web user would take away from such a popup is that github.com is annoying or spying on them, and then proceed to bombard github with messages to knock it off (reminds me of when a blog temporarily became the #1 search term for "facebook login", oh the hate that blog received for "breaking my Facebooks")
- TazeTSchnitzel 12y agoThe average web user has no idea GitHub is behind the popup. You need to be a web expert and look at the Network tab to know this.
- Rezo 12y agoOP suggested adding "github.com" to the popup's message. That would be a Bad Idea.
- TazeTSchnitzel 12y agoOh, right, silly me for not reading the context.
- deleted 12y ago[deleted]
- zupa-hu 12y agoWhat about alert("The site you are visiting contains malicious JavaScript. It uses your machine as part of a cyber attack. You must immediately alert owners of this website to remove Baidu analytics which distributes the malware.")
- lkbm 12y agoOr perhaps use it to advertise a Baidu competitor. Okay, I'm guessing this isn't on Baidu so much as the Chinese governments, but incentivizing Chinese corporations to object to government attacks isn't a terrible idea.