4 ms·

Committing downloaded packages is not a bad practice. Yes, it can be a bit big, but otherwise I don't see much problem with it. You will be always sure that the

Committing downloaded packages is not a bad practice. Yes, it can be a bit big, but otherwise I don't see much problem with it. You will be always sure that the installed packages are compatible with each other.

tsheeeep 12y ago
To be sure everything that we know works together we use things like npm-shrinkwrap files. We don't like it because it makes the git changelogs a lot bigger and almost unreadable if you want to compare a pull request.
- Already__Taken 12y ago
  Yes the way you should do it is with shrinwrap to ensure the consistency of your dependencies. As for the actual files if you depend on it you should have your own npm repo caching them that you deploy from and have that mirror the public one. but for small projects or quick deploys absolutely just go ahead and commit the modules.
- __david__ 12y ago
  You could commit them to their own repository so they don't taint your main repo. Then use a submodule to pull that repo in to the main repo...
- STRML 12y ago
  Try https://github.com/uber/npm-shrinkwrap https://github.com/uber/npm-shrinkwrap, it produces deterministic shrinkwrap files that actually diff properly.
astrodust 12y ago
That works great until you have compiled extensions. Then it's misery.