3 ms·
Just wanted to say: If you do not quickly clue into the fact that Array#pack was redefined in a file you've never seen before that was committed last Tuesday b
by thenduks 17y ago
Just wanted to say:
If you do not quickly clue into the fact that Array#pack was redefined in a file you've never seen before that was committed last Tuesday by your most junior developer in the Seoul office, enjoy spending the next several days going over code you swear looks right looking for the error.
Code reviews are absolutely required with any dynamic language. It's a good practice anyway, to keep everyone on the same page.
- jshen 17y agoi'd also wonder why a unit test didn't catch this. In my experience if you catch a bug close to the time of it's introduction, it's easy to debug.
- thenduks 17y agoAgreed. In fact, I'd say that doing code reviews would not only catch this problem but also the fact that the test for it is missing.
- tptacek 17y agoWhere by absolutely required you mean pretty useful.
- thenduks 17y agoI hope I don't sound too argumentative but, no, I mean absolutely required. I review my own code (and not just casually, either) a few days later and where I work we all read every commit.
- tptacek 17y agoIt's so "absolutely required" that most of the most popular web applications, all written in dynamic languages, are not the product of reviewed codebases. You don't sound argumentative. You sound hyperbolic.
- thenduks 17y agoI don't think we're on the same page about what 'code review' is. I'm only talking about having your co-workers/peers look at your code and keep up to speed on what's happening to the code base you're all working on. Do you have a citation for 'most' of the popular web applications not being code reviewed? Have the developers at, say, twitter said they ignore commits and code written by co-workers?