4 ms·
Looks good, and I like that you're aiming to make it lightweight. However, I'd take another "do we need this" pass to eliminate dependency bulk. For example, I
by CognitiveLens 12y ago
Looks good, and I like that you're aiming to make it lightweight. However, I'd take another "do we need this" pass to eliminate dependency bulk.
For example, I'd avoid having a (somewhat) verbose plugin dependency to shim `console.log` - it's very easy to avoid hitting that incompatibility in most development. Similar argument against including es5-shim - it's super easy to add that if/when you need it, but it's orthogonal to building a react application.
Also, I'd be wary of incorporating Radium - it will narrow the audience because it brings another set of dev requirements., and it's really not Essential to building a react app, it's just a nice-to-have if it fits your dev style.
Will definitely be interested in trying this out next time I'm playing with React, though - thanks for sharing it!
- gmaster1440 12y agoThanks for the great feedback! You make really good points, and I will surely take additional passes to optimize. It's just the beginning, looking forward to further tuning it :)