3 ms·
At GitLab we recently implemented this in our tests. After this all the reminders and comments about style are no longer needed. You just need to have green tes
by sytse 12y ago
At GitLab we recently implemented this in our tests. After this all the reminders and comments about style are no longer needed. You just need to have green tests as you always should. We think having it in CI is a much better experience than a HoundCI that makes line comments in the merge request, that gets quite noisy for people following the MR.
- ericb 12y agoDo you have some code to make it a spec by chance? I've been thinking about doing that.
- sytse 12y agoA link to the settings we use is here https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.rubocop.yml https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.rubocop... it is pretty loose since we recently implemented it and didn't want to have to fix 1600 files :)