5 ms·
I have migrated yesterday from 7.3 to 7.8 and all went smoothly, I really appreciate the migration guide and especially the "what to do if things go south" whic
by allan_s 12y ago
I have migrated yesterday from 7.3 to 7.8 and all went smoothly, I really appreciate the migration guide and especially the "what to do if things go south" which is always my biggest concern.
My only little problem is that now the list of merge request display the assignee instead of the creator. It does not really make sense to me as there's already the filter "assigned to me". It breaks a little my workflow because I do code reviewing for a dozen of person across several project, and when they tell me on skype "pushed" , now i need to ask them "errrr which MR number?"
- sytse 12y agoGlad to hear your upgrade went OK. I made the change to show the assignee. We think it is more important to show what has to be done than to show what has been done. But I agree that for your use case it might be a small step back. What about filtering the MR's by author as you can do on https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests ?
- allan_s 12y agoI understand the logic, but however it does not stand to the fact that on the homepage when I click on MR I already see a filtered version of "only those assigned to me" , which in that case make the display of the assignee redundant, and I hardly specifically go on the project page then on MR. EDIT: I would have nothing against a middle ground of displaying both. thanks for your quick feedback.
- sytse 12y agoIt makes sense that if you go to https://gitlab.com/dashboard/merge_requests?assignee_id=1 https://gitlab.com/dashboard/merge_requests?assignee_id=1 it shows the author instead of the assignee. Same for other places where you filter on assignee. Feel free to create a merge request for this. We can't display both since it will look messy.
- allan_s 12y agoyes your solution of displaying author when assignee is already filtered. I don't know ruby at all, but I guess I can try, as you're the one who made the change to put assignee instead of author, I would not be against some guidance on where to look for the modification :)
- sytse 12y agoYou can find it here https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/projects/merge_requests/_merge_request.html.haml#L27 https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/view...
- allan_s 12y agothank you, I'm a bit confused by the code (the fact I know nothing about ruby, let alone rails, without talking about haml may be part of it) in my naive understanding, in order to implement the feature as you said, it would require from the controller to send to the view a variable "isFilteredByAssignee" How can one find the corresponding controller, I've tried grepping for _merge_request.html.haml or just _merge_request without finding anything. I guess the index.html.haml in the folder do something magic to render the list of merge_request with the @merge_requests ?
- sytse 12y agoI just discussed this with some other team-members. The consensus is that changing what information is displayed is confusing. We don't have a lot of space to work but but we can add 'by' and an avatar. So go from: #337 assigned to Sytse Sijbrandij => #337 by AVATAR assigned to AVATAR Sytse Sijbrandij When you hover over the avatar it should show the name of the author in a tooltip. If you don't feel comfortable making this please make it into a feature request on http://feedback.gitlab.com/forums/176466-general http://feedback.gitlab.com/forums/176466-general
- allan_s 12y ago