3 ms·
> "In general, pull request culture is not about code review." > I have no idea what this means. Me either. To me, the entire point of pull requests is about
by MaulingMonkey 12y ago
> "In general, pull request culture is not about code review."
> I have no idea what this means.
Me either. To me, the entire point of pull requests is about triggering (code) reviews. If I don't want to bother with review, why not just grant direct push access and skip the rubber stamp ceremony?
- yawaramin 12y agoPull request culture is about enabling distributed collaboration, i.e. I don't have push permission to your repo and you don't have push permission to mine, but we can still collaborate by sending each other pull requests and sharing our work that way. It's all about collaboration while not trusting the other person with write access to your repo.
- MaulingMonkey 12y ago> It's all about collaboration while not trusting the other person with write access to your repo. If I don't trust someone enough to grant write access to my repo, I certainly don't trust them enough to rubber stamp their pull requests.
- yawaramin 12y agoNor should you. You treat their pull requests just as you should any code review: you study them and decide whether to approve (accept) them or not.