4 ms·

It looks really great, changing color via CSS is neat! maybe you could put the license information on that page! (The github page says it is MIT License for th

by vmarsy 12y ago

It looks really great, changing color via CSS is neat! maybe you could put the license information on that page! (The github page says it is MIT License for those who wonder) btw the french flag is backwards (Blue - White - Red is the good one) EDIT: Thanks for the flag fix benjamin!

cabmaddux 12y ago
For sure, thanks for taking a look! And good eye on the French flag! I'll get that fixed up. I'll make sure to add license info to that demo/download page. Thanks again, a huge help!
- tschuy 12y ago
  Aditionally, with the flags, I noticed that you have Switzerland as a rectangle. I know that's not an uncommon representation of it, but its flag is actually a square. Just an fyi :)
  - Someone 12y ago
    And in the "pedantic++" category: check out flag proportions, too. See for example https://flagspot.net/flags/nl-lu.html https://flagspot.net/flags/nl-lu.html, which explains the difference between the flags of Monaco and Indonesia (buried in a discussion about the flags of the Netherlands and Luxembourg): same colors, but different proportions. So, Belgium should be 13:15 (https://flagspot.net/flags/be.html https://flagspot.net/flags/be.html, for US flags 10:19 seems best for all uses (https://flagspot.net/flags/us-size.html#prop https://flagspot.net/flags/us-size.html#prop), etc. But that certainly is just a fyi :)
k_ 12y ago
I like it :) Something that could further ease the color customization would be to use currentColor [1] on the border colors, allowing the customization to be made simply by changing the "color" attribute of the element. [1] http://tympanus.net/codrops/css_reference/color_value/#section_currentColor http://tympanus.net/codrops/css_reference/color_value/#secti... which I discovered with https://twitter.com/SaraSoueidan/status/564090319117881344 https://twitter.com/SaraSoueidan/status/564090319117881344

by vmarsy 12y ago

cabmaddux 12y ago

For sure, thanks for taking a look! And good eye on the French flag! I'll get that fixed up. I'll make sure to add license info to that demo/download page. Thanks again, a huge help!

tschuy 12y ago
Aditionally, with the flags, I noticed that you have Switzerland as a rectangle. I know that's not an uncommon representation of it, but its flag is actually a square. Just an fyi :)
- Someone 12y ago
  And in the "pedantic++" category: check out flag proportions, too. See for example https://flagspot.net/flags/nl-lu.html https://flagspot.net/flags/nl-lu.html, which explains the difference between the flags of Monaco and Indonesia (buried in a discussion about the flags of the Netherlands and Luxembourg): same colors, but different proportions. So, Belgium should be 13:15 (https://flagspot.net/flags/be.html https://flagspot.net/flags/be.html, for US flags 10:19 seems best for all uses (https://flagspot.net/flags/us-size.html#prop https://flagspot.net/flags/us-size.html#prop), etc. But that certainly is just a fyi :)

k_ 12y ago

I like it :) Something that could further ease the color customization would be to use currentColor [1] on the border colors, allowing the customization to be made simply by changing the "color" attribute of the element. [1] http://tympanus.net/codrops/css_reference/color_value/#section_currentColor http://tympanus.net/codrops/css_reference/color_value/#secti... which I discovered with https://twitter.com/SaraSoueidan/status/564090319117881344 https://twitter.com/SaraSoueidan/status/564090319117881344