4 ms·

I guess the advantage of Linthub over Phare is that it can run on pull requests made by external contributors.

• nl5887 12y ago
  This is exactly why we've develop this. To enforce code quality to pull requests and save the repository owners time.
  • bhuga 12y ago
    I think he's commenting on the approach of how the system reports, not its usefulness. Have you considered bundling up the results as a second commit status[1] rather than making comments? 1: https://github.com/blog/1935-see-results-from-all-pull-request-status-checks https://github.com/blog/1935-see-results-from-all-pull-reque...
    • jbrooksuk 12y ago
      Adding a commit status would be nice. It'd fail whilst the most recent commit has had a commit-comment on it.
      • nl5887 12y ago
        The commit status have been added :-).
        • bhuga 12y ago
          That was quick. Awesome! Do you have a sample pull with the new setup?
• remi 12y ago
  Actually, it does in a certain way. Travis runs builds (tests + Phare) for all pull requests (eg. https://travis-ci.org/mirego/encore/pull_requests https://travis-ci.org/mirego/encore/pull_requests) so we know if pull requests made by external contributors "break the build".
  • nl5874 12y ago
    Yes, true, but only if it breaks. This enforces common code quality issues, so it will run side-to-side with travis.
    • ayrx 12y ago
      In all my projects (and the projects I contribute to), style issues are a build-breaking defect. In Python this usually means running flake8 as a Travis job.