6 ms·

Linthub: Static code analysis for GitHub pull requests

70 points by nl5874 12y ago

zidar 12y ago
This looks pretty awesome and will just get better as more languages get supported. But, it comments on commits, not on the diff in the PR. I think commeting on the diff looks nicer (you see code snippet with the comment) and in my opinion it's also easyer to find all the comments that way. Instead of clicking the commit hash on the commen each time.
- nl5874 12y ago
  Thanks! Will check and handle this.
  - nl5887 12y ago
    The release with commenting on pull requests is active now. Linthubot will comment on the pull request itself instead of the commit.
- nl5887 12y ago
  Added Python and Ruby support btw. Supporting 9 languages now.
jbrooksuk 12y ago
So this is like Hound[1]? - I am (kinda) building something for PHP, Anorak[2] which uses something else I built. What's your plan on this? I'd like to use it for our private repositories. Edit: My web hooks are returning errors. I'll submit some feedback. [1] https://houndci.com https://houndci.com [2] https://github.com/jbrooksuk/anorak https://github.com/jbrooksuk/anorak
- nl5874 12y ago
  It seems comparable, though we are supporting different languages. Plans are to support a lot more languages, and support private repos also. (Actually they are already supported, but linthubot needs to have read only access to the repository). All feedback is welcome.
  - jbrooksuk 12y ago
    Thanks! Are you planning on charging for this? I have an error, can I email you guys? Edit: Nevermind, I found the support form.
    - nl5874 12y ago
      Currently no plans for charging. If we'll change these plans, existing repositories will stay free. Send an email to support@linthub.io for the error, and we'll check it immediatly.
    - nl5874 12y ago
      Error should be fixed, was an error due to redirect http to https.
remi 12y ago
Instead of using a service like this one (or Hound) that comments directly on pull requests, we chose to integrate the same tools in our build process with Phare (https://github.com/mirego/phare https://github.com/mirego/phare), a command-line tool we built which runs Rubocop, JSHint, JSCS, etc. and exits with a global status. If the code has coding style violations, the build breaks. Exactly like it would if we pushed a failing test. Personally, I’m not a fan of the noise generated by comments about coding style on pull requests.
- hk__2 12y ago
  I guess the advantage of Linthub over Phare is that it can run on pull requests made by external contributors.
  - nl5887 12y ago
    This is exactly why we've develop this. To enforce code quality to pull requests and save the repository owners time.
    - bhuga 12y ago
      I think he's commenting on the approach of how the system reports, not its usefulness. Have you considered bundling up the results as a second commit status[1] rather than making comments? 1: https://github.com/blog/1935-see-results-from-all-pull-request-status-checks https://github.com/blog/1935-see-results-from-all-pull-reque...
      - jbrooksuk 12y ago
        Adding a commit status would be nice. It'd fail whilst the most recent commit has had a commit-comment on it.
        nl5887 12y ago
        The commit status have been added :-).
lsaferite 12y ago
Does github not have granular enough permissions to allo commenting on pull requests without granting write access to a repo?
- nl5887 12y ago
  Yeah, true. We've tightened the scope, read/write is not necessary any longer. Only for private repo's, the linthubot user needs to be added to the repo with read access.
untitaker_ 12y ago
Similar services: https://houndci.com/ https://houndci.com/ http://scrutinizer-ci.com/ http://scrutinizer-ci.com/ http://landscape.io/ http://landscape.io/ http://codeclimate.com/ http://codeclimate.com/
- jbrooksuk 12y ago
  I've been working another alternative; https://github.com/jbrooksuk/anorak https://github.com/jbrooksuk/anorak
- jaimefjorge 12y ago
  Also: https://www.codacy.com https://www.codacy.com :)
- joncp 12y ago
  Does anyone know how these services stack up against each other? I use CodeClimate and it rocks, but I'm curious about how the others work.
  - carlio 12y ago
    I may be biased as I made Landscape.io, but it rocks too!
jchomali 12y ago
This look awesome! But there are a lot of similar services such as codeclimate.
dominotw 12y ago
Are there any opensource tools that do the same thing( like reek for ruby) ? I would like to use something like this at work but we don't host code on github.
- russianbandit 12y ago
  Try RuboCop for ruby.
konradko 12y ago
There is a free open source alternative written in Python: https://github.com/justinabrahms/imhotep https://github.com/justinabrahms/imhotep It runs on the commit diff with a specified linting tool (used it with pep8 and jshint), it is also fairly easy to add new linters. Here's a fork that works nicely with Travis: https://github.com/glowdigitalmedia/imhotep https://github.com/glowdigitalmedia/imhotep

70 points by nl5874 12y ago

zidar 12y ago

This looks pretty awesome and will just get better as more languages get supported. But, it comments on commits, not on the diff in the PR. I think commeting on the diff looks nicer (you see code snippet with the comment) and in my opinion it's also easyer to find all the comments that way. Instead of clicking the commit hash on the commen each time.

nl5874 12y ago
Thanks! Will check and handle this.
- nl5887 12y ago
  The release with commenting on pull requests is active now. Linthubot will comment on the pull request itself instead of the commit.
nl5887 12y ago
Added Python and Ruby support btw. Supporting 9 languages now.

jbrooksuk 12y ago

So this is like Hound[1]? - I am (kinda) building something for PHP, Anorak[2] which uses something else I built. What's your plan on this? I'd like to use it for our private repositories. Edit: My web hooks are returning errors. I'll submit some feedback. [1] https://houndci.com https://houndci.com [2] https://github.com/jbrooksuk/anorak https://github.com/jbrooksuk/anorak

nl5874 12y ago
It seems comparable, though we are supporting different languages. Plans are to support a lot more languages, and support private repos also. (Actually they are already supported, but linthubot needs to have read only access to the repository). All feedback is welcome.
- jbrooksuk 12y ago
  Thanks! Are you planning on charging for this? I have an error, can I email you guys? Edit: Nevermind, I found the support form.
  - nl5874 12y ago
    Currently no plans for charging. If we'll change these plans, existing repositories will stay free. Send an email to support@linthub.io for the error, and we'll check it immediatly.
  - nl5874 12y ago
    Error should be fixed, was an error due to redirect http to https.

remi 12y ago

Instead of using a service like this one (or Hound) that comments directly on pull requests, we chose to integrate the same tools in our build process with Phare (https://github.com/mirego/phare https://github.com/mirego/phare), a command-line tool we built which runs Rubocop, JSHint, JSCS, etc. and exits with a global status. If the code has coding style violations, the build breaks. Exactly like it would if we pushed a failing test. Personally, I’m not a fan of the noise generated by comments about coding style on pull requests.

hk__2 12y ago
I guess the advantage of Linthub over Phare is that it can run on pull requests made by external contributors.
- nl5887 12y ago
  This is exactly why we've develop this. To enforce code quality to pull requests and save the repository owners time.
  - bhuga 12y ago
    I think he's commenting on the approach of how the system reports, not its usefulness. Have you considered bundling up the results as a second commit status[1] rather than making comments? 1: https://github.com/blog/1935-see-results-from-all-pull-request-status-checks https://github.com/blog/1935-see-results-from-all-pull-reque...
    - jbrooksuk 12y ago
      Adding a commit status would be nice. It'd fail whilst the most recent commit has had a commit-comment on it.
      - nl5887 12y ago
        The commit status have been added :-).

lsaferite 12y ago

Does github not have granular enough permissions to allo commenting on pull requests without granting write access to a repo?

nl5887 12y ago
Yeah, true. We've tightened the scope, read/write is not necessary any longer. Only for private repo's, the linthubot user needs to be added to the repo with read access.

untitaker_ 12y ago

Similar services: https://houndci.com/ https://houndci.com/ http://scrutinizer-ci.com/ http://scrutinizer-ci.com/ http://landscape.io/ http://landscape.io/ http://codeclimate.com/ http://codeclimate.com/

jbrooksuk 12y ago
I've been working another alternative; https://github.com/jbrooksuk/anorak https://github.com/jbrooksuk/anorak
jaimefjorge 12y ago
Also: https://www.codacy.com https://www.codacy.com :)
joncp 12y ago
Does anyone know how these services stack up against each other? I use CodeClimate and it rocks, but I'm curious about how the others work.
- carlio 12y ago
  I may be biased as I made Landscape.io, but it rocks too!

jchomali 12y ago

This look awesome! But there are a lot of similar services such as codeclimate.

dominotw 12y ago

Are there any opensource tools that do the same thing( like reek for ruby) ? I would like to use something like this at work but we don't host code on github.

russianbandit 12y ago
Try RuboCop for ruby.

konradko 12y ago

There is a free open source alternative written in Python: https://github.com/justinabrahms/imhotep https://github.com/justinabrahms/imhotep It runs on the commit diff with a specified linting tool (used it with pep8 and jshint), it is also fairly easy to add new linters. Here's a fork that works nicely with Travis: https://github.com/glowdigitalmedia/imhotep https://github.com/glowdigitalmedia/imhotep