5 ms·
Mostly we use github. Using pull requests is a great way to being able to review code commits.
by nicogevers 12y ago
Mostly we use github. Using pull requests is a great way to being able to review code commits.
- piotrkaminski 12y agoGitHub's a good start but PRs have some non-trivial limitations when it comes to reviewing code efficiently. Tools are springing up to help devs work around the problems without abandoning GitHub. You can take a look at GitColony, Sourcegraph, Review Ninja, and Reviewable (disclosure: this one's mine).
- mfocaraccio 12y agoI definitely agree with this (disclosure: I'm Gitcolony's founder). I think that PRs are a great start point but not the best way to review code in a company. I do believe they are great option for open source contributions but not the most efficient one for companies.
- benboeser 12y ago+1 on Piotrs comment (disclosure: founding team of ReviewNinja - http://review.ninja http://review.ninja). We also found that most users like to put some more structure around their code review and appreciate the fact that tools like the ones mentioned by Piotr give more visibility into outstanding issues that need to be closed, before a pull request can be merged. It is also helpful for most to get a better handling around who 'approved' (+1ed) a PR.