5 ms·
> And you cannot expect a variable to be defined outside of its lexical scope. Okay, but since `typeof x` can return "undefined", I would expect it to return `
by jrochkind1 12y ago
> And you cannot expect a variable to be defined outside of its lexical scope.
Okay, but since `typeof x` can return "undefined", I would expect it to return `undefined` if x is no defined. Now, sometimes `typeof x` returns `undefined` if x is not defined, but other times it raises if x is no defined. That's the issue.
I too predict this is going to give people a lot of trouble. We will see.
- TeMPOraL 12y agoAnd the worst thing is, introducing a let variable affects code outside of the implicit lexical scope created by that let. The switch from "undefined" to "more undefined" happens one scope above. Even if it doesn't create much of a trouble for people, it feels like a very ugly design.
- ajanuary 12y agotypeof isn't raising the exception, the runtime is raising it before typeof is even evaluated.
- jrochkind1 12y agoI understand the implementation details, but the fact remains that previously you could call `typeof something` for any `something` at all, and it would never throw, ever. So you could use it as a way to check if a variable was defined. Now, sometimes it will throw. I mean, come on, you really don't see anything confusing in the fact that there are now two kinds of `undefined`, one kind you can call `typeof x` and it returns `undefined`, but another kind of undefined where you can't mention x at all without a throw? Like, if you can't mention undefined variables without getting a throw, how come `typeof` sometimes returns `undefined`? Ah, because some "undefined" variables you can do that with, but not others? So I guess there is more than one "kind" of "undefined" now? This is not confusing?
- ajanuary 12y ago> Now, sometimes it will throw. No, typeof /isn't/ throwing. let x = 1; function some_random_function(y) { } (function() { some_random_function(x); let x = 2; })(); This will throw the same exception for exactly the same reason. You're using a variable defined using "let" before the variable definition. Sod all to do with typeof. I don't see it as massively confusing that a variable declared one way behaves differently to a variable declared another way. That's the whole point of having a new way of declaring a variable. Why isn't everyone up in arms about how confusing it is that it behaves differently here? (function() { var x = 1; if (true) { var x = 10; } console.log(x); // Will print 10 })(); (function() { let x = 1; if (true) { let x = 10; } console.log(x); // Will print 1 })(); Oh no, if I use "let" it behaves differently to "var"! Its not like its throwing on unexpected data, its throwing because the program isn't constructed properly. This is the same as just about every other language. Are you really saying we shouldn't make improvements to the language because then it would behave differently to the old, poorly designed features we're trying to deprecate? [edit] You still can use typeof to check if something is defined without throwing on spurious inputs. The only time the code will throw is if you make changes to further down in the lexical scope. And guess what - whether you do that with var or with let you've changed the argument of typeof to refer to a different variable. Except with var it will likely silently fail in a hard to track down way, while with let it will error in an obvious place. let data; function sanitizeData() { if (typeof data === 'undefined') { // data not yet set return; } // sanitize data in place } No matter what you put in data, "typeof data" is never going to throw an exception. The only way to get it to throw an exception is to change sanitizeData to add a variable shadowing "data" from the parent scope. let data; function sanitizeData() { if (typeof data === 'undefined') { // data not yet set return; } // sanitize data in place var data = ...; // sanitize data in place } If I use var, sanitizeData doesn't do anything and I spent a while hunting the issue down. let data; function sanitizeData() { if (typeof data === 'undefined') { // data not yet set return; } // sanitize data in place let data = ...; // sanitize data in place } If I use let, sanitizeData throws as soon as it's called and I can track down the issue much quicker. The only time "typeof throws an exception" is if you add a let statement later in the lexical scope in a place where if you added a var statement, it would completely change the behaviour of your code in a way you almost certainly didn't want it to.