4 ms·
If you're working in a team the code review workflow is a bit better, because as a reviewer you can explicitly Approve a pull request. I've used it in a team w
by warp 12y ago
If you're working in a team the code review workflow is a bit better, because as a reviewer you can explicitly Approve a pull request. I've used it in a team where the requirement was to get two approvals before a pull request can be shipped. Having the number of approvals visible on the pull request list/overview screen is a tiny detail, but very useful.
At my current job we're using a "ship it" label on GitHub to track this, I really don't understand why GitHub still cannot track this in a native way.
- pmelendez 12y agoIt's a bit of offtopic, but I had worked in a similar setup but we were using phabricator for code reviews and it is hands down the best tool for code review that I have ever used.
- sytse 12y agoGitLab B.V. CEO here, in GitLab we show the number of +1 and -1 at the top of the merge request for this reason.