4 ms·
Architectural or design problems need to be fixed before merge. Code review incentives only align if the patch isn't merged until it passes review (e.g. Linux)
by dustingetz 12y ago
Architectural or design problems need to be fixed before merge.
Code review incentives only align if the patch isn't merged until it passes review (e.g. Linux).
If patches are merged before review, a code review is really just "hey FYI I did this, any glaring problems?". You may need some other methodology to fix architectural or design problems before the review. Pair programming does this for some teams, for other teams its only hiring developers they trust.